After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678331 - Sending a file from the conversation window silently fails
Sending a file from the conversation window silently fails
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: File Transfer
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-06-18 15:13 UTC by Will Thompson
Modified: 2012-06-26 09:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
don't display 'Send file' menu item in empathy-chat (3.19 KB, patch)
2012-06-25 13:16 UTC, Guillaume Desmottes
committed Details | Review
chat-window: disable file transfer DnD (1.01 KB, patch)
2012-06-25 13:16 UTC, Guillaume Desmottes
committed Details | Review

Description Will Thompson 2012-06-18 15:13:47 UTC
With Empathy 3.4.2.1 (Debian), choose Contact → Send File, or drag a file into the conversation window. Nothing happens. The debug log shows this:

empathy/Ft-DEBUG: 18/06/12 15:56:47.322700: empathy_ft_handler_new_outgoing: New handler outgoing
empathy/Ft-DEBUG: 18/06/12 15:56:47.341650: ft_handler_gfile_ready_cb: Got GFileInfo.
empathy/Ft-DEBUG: 18/06/12 15:56:47.344687: set_content_hash_type_from_classes: Hash enabled True; setting content hash type as 1
GLib-GObject-WARNING: 18/06/12 15:56:47.344722: instance of invalid non-instantiatable type `(null)'
GLib-GObject-CRITICAL: 18/06/12 15:56:47.344737: g_signal_emit_valist: assertion `G_TYPE_CHECK_INSTANCE (instance)' failed

and here's a backtrace:

Program received signal SIGTRAP, Trace/breakpoint trap.
g_logv (log_domain=0x7f501d66bf6c "GLib-GObject", log_level=G_LOG_LEVEL_CRITICAL, 
    format=0x7f501d3cd6e2 "%s: assertion `%s' failed", args1=args1@entry=0x7fff3c417ec8)
    at /tmp/buildd/glib2.0-2.32.3/./glib/gmessages.h:101
101	/tmp/buildd/glib2.0-2.32.3/./glib/gmessages.h: No such file or directory.
(gdb) bt
  • #0 g_logv
    at /tmp/buildd/glib2.0-2.32.3/./glib/gmessages.h line 101
  • #1 g_log
    at /tmp/buildd/glib2.0-2.32.3/./glib/gmessages.c line 792
  • #2 g_return_if_fail_warning
  • #3 g_signal_emit_valist
    at /tmp/buildd/glib2.0-2.32.3/./gobject/gsignal.c line 3083
  • #4 g_signal_emit
    at /tmp/buildd/glib2.0-2.32.3/./gobject/gsignal.c line 3352
  • #5 check_hashing
    at empathy-ft-handler.c line 1216
  • #6 ft_handler_gfile_ready_cb
    at empathy-ft-handler.c line 1297
  • #7 g_simple_async_result_complete
    at /tmp/buildd/glib2.0-2.32.3/./gio/gsimpleasyncresult.c line 767
  • #8 complete_in_idle_cb_for_thread
    at /tmp/buildd/glib2.0-2.32.3/./gio/gsimpleasyncresult.c line 835
  • #9 g_main_dispatch
    at /tmp/buildd/glib2.0-2.32.3/./glib/gmain.c line 2539
  • #10 g_main_context_dispatch
    at /tmp/buildd/glib2.0-2.32.3/./glib/gmain.c line 3075
  • #11 g_main_context_iterate
    at /tmp/buildd/glib2.0-2.32.3/./glib/gmain.c line 3146
  • #12 g_main_context_iteration
  • #0 g_logv
    at /tmp/buildd/glib2.0-2.32.3/./glib/gmessages.h line 101
  • #1 g_log
    at /tmp/buildd/glib2.0-2.32.3/./glib/gmessages.c line 792
  • #2 g_return_if_fail_warning
  • #3 g_signal_emit_valist
    at /tmp/buildd/glib2.0-2.32.3/./gobject/gsignal.c line 3083
  • #4 g_signal_emit
    at /tmp/buildd/glib2.0-2.32.3/./gobject/gsignal.c line 3352
  • #5 check_hashing
    at empathy-ft-handler.c line 1216
  • #6 ft_handler_gfile_ready_cb
    at empathy-ft-handler.c line 1297
  • #7 g_simple_async_result_complete
    at /tmp/buildd/glib2.0-2.32.3/./gio/gsimpleasyncresult.c line 767
  • #8 complete_in_idle_cb_for_thread
    at /tmp/buildd/glib2.0-2.32.3/./gio/gsimpleasyncresult.c line 835
  • #9 g_main_dispatch
    at /tmp/buildd/glib2.0-2.32.3/./glib/gmain.c line 2539
  • #10 g_main_context_dispatch
    at /tmp/buildd/glib2.0-2.32.3/./glib/gmain.c line 3075
  • #11 g_main_context_iterate
    at /tmp/buildd/glib2.0-2.32.3/./glib/gmain.c line 3146
  • #12 g_main_context_iteration
    at /tmp/buildd/glib2.0-2.32.3/./glib/gmain.c line 3207
  • #13 g_application_run
    at /tmp/buildd/glib2.0-2.32.3/./gio/gapplication.c line 1507
  • #14 main
    at empathy-chat.c line 166

Comment 1 Guillaume Desmottes 2012-06-25 12:55:14 UTC
FT from empathy-chat is meant to be disabled because of bug #640513

I guess I accidentally re-enabled it in 3.4 when refactoring some code.
Comment 2 Guillaume Desmottes 2012-06-25 13:16:47 UTC
Created attachment 217195 [details] [review]
don't display 'Send file' menu item in empathy-chat

We only support requesting FT channel in the same process as the FT handler.
Comment 3 Guillaume Desmottes 2012-06-25 13:16:50 UTC
Created attachment 217196 [details] [review]
chat-window: disable file transfer DnD

It's not supported at the moment.
Comment 4 Xavier Claessens 2012-06-26 09:05:28 UTC
it's sad to not support this, but since it does not work anyway, +1.
Comment 5 Guillaume Desmottes 2012-06-26 09:16:01 UTC
Attachment 217195 [details] pushed as 13d6036 - don't display 'Send file' menu item in empathy-chat
Attachment 217196 [details] pushed as 8d84c17 - chat-window: disable file transfer DnD