After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677627 - implicit declaration of pango_config_key_get_system
implicit declaration of pango_config_key_get_system
Status: RESOLVED DUPLICATE of bug 667960
Product: pango
Classification: Platform
Component: general
1.30.x
Other Windows
: Normal normal
: ---
Assigned To: pango-maint
pango-maint
Depends on:
Blocks:
 
 
Reported: 2012-06-07 12:30 UTC by Dominique Leuenberger
Modified: 2012-08-21 21:28 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Dominique Leuenberger 2012-06-07 12:30:08 UTC
While building pango 0.30.1 (latest stable), the open Build Service aborts the build due to detected implicit declarations.

From the build log:
***
  CC     querymodules.o
querymodules.c: In function 'main':
querymodules.c:245:2: warning: implicit declaration of function 'pango_config_key_get_system' [-Wimplicit-function-declaration]
querymodules.c:245:7: warning: assignment makes pointer from integer without a cast [enabled by default]
  CCLD   libpango-1.0.la
****

pango_config_key_get_system is being referenced (using grep) in:
pango/pango-utils.c: * pango_config_key_get_system:
pango/pango-utils.c:pango_config_key_get_system (const char *key)
pango/querymodules.c:   path = pango_config_key_get_system ("Pango/ModulesPath");
pango/pango.def:        pango_config_key_get_system

pango-utils.c has a declaration of this function, but querymodules.c does not have any prototype information, thus resulting in the warning / error.

This patch solves the issue on my builds:
Index: pango-1.30.1/pango/pango-utils.h
===================================================================
--- pango-1.30.1.orig/pango/pango-utils.h
+++ pango-1.30.1/pango/pango-utils.h
@@ -48,6 +48,8 @@ void     pango_lookup_aliases (const cha
                               int          *n_families);
 #endif /* PANGO_ENABLE_BACKEND */

+char *   pango_config_key_get_system (const char *key);
+
 gboolean pango_parse_enum     (GType       type,
                               const char *str,
                               int        *value,
Comment 1 Dominique Leuenberger 2012-08-21 21:28:24 UTC
Flagging my bug as dup of 667960 (which got fixed after all)

*** This bug has been marked as a duplicate of bug 667960 ***