After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 667960 - querymodules: Add --system argument
querymodules: Add --system argument
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: pango-maint
pango-maint
: 677627 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-01-15 14:46 UTC by Colin Walters
Modified: 2012-08-21 21:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
querymodules: Add --system argument (3.96 KB, patch)
2012-01-15 14:46 UTC, Colin Walters 		committed Details | Review
declare pango_config_key_get_system (403 bytes, patch)
2012-06-16 09:11 UTC, Fabian Groffen 		committed Details | Review

Description Colin Walters 2012-01-15 14:46:38 UTC 
When run as a system trigger, we really don't want to be consulting
e.g. /root/.pangorc.  Also, the OSTree build system can run as
non-root, but we don't in this case want to look at /home/user since
the user may not even exist in the password database inside the
chroot.
Comment 1 Colin Walters 2012-01-15 14:46:40 UTC 
Created attachment 205302 [details] [review]
querymodules: Add --system argument
Comment 2 Behdad Esfahbod 2012-05-09 21:42:26 UTC 
Conceptually this makes sense to me.
Comment 3 Colin Walters 2012-05-10 15:41:32 UTC 
Attachment 205302 [details] pushed as aecbe27 - querymodules: Add --system argument
Comment 4 Colin Walters 2012-05-10 15:42:04 UTC 
(In reply to comment #2)
> Conceptually this makes sense to me.

Ok, I'm pretty confident in this patch, so let's go with it.  I'll be on point of course for any possible regressions.
Comment 5 Fabian Groffen 2012-06-16 09:11:08 UTC 
Created attachment 216557 [details] [review]
declare pango_config_key_get_system

Could you guys please define the new function in pango/pango-utils.h?

Gentoo's a bit strict on compilation warnings resulting from this on 64-bits arches:

 * QA Notice: Package triggers severe warnings which indicate that it
 *            will almost certainly crash on 64bit architectures.
 * 
 * Function `pango_config_key_get_system' implicitly converted to pointer at que
rymodules.c:245

Attached patch works for me.
Comment 6 Dominique Leuenberger 2012-08-21 21:28:24 UTC 
*** Bug 677627 has been marked as a duplicate of this bug. ***