After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677300 - Add 3 px padding above and below the searchbar
Add 3 px padding above and below the searchbar
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Shell
3.4.x (obsolete)
Other Linux
: Normal trivial
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2012-06-01 19:16 UTC by Jean-François Fortin Tam
Modified: 2014-01-12 23:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (78.30 KB, image/png)
2012-06-01 19:16 UTC, Jean-François Fortin Tam 		  Details
mockup (87.26 KB, image/png)
2012-06-01 19:17 UTC, Jean-François Fortin Tam 		  Details
proposed patch (untested) (797 bytes, patch)
2013-04-06 15:51 UTC, Jean-François Fortin Tam 		committed Details | Review

Description Jean-François Fortin Tam 2012-06-01 19:16:56 UTC 
Created attachment 215463 [details]
screenshot

For HIG compliance and better aesthetics, please add 3 pixels of spacing/padding below and above the search bar. That should make it feel less cramped below the main toolbar, with almost insignificant loss of vertical space (in exchange for better usability).
Comment 1 Jean-François Fortin Tam 2012-06-01 19:17:19 UTC 
Created attachment 215464 [details]
mockup
Comment 2 Matthew Barnes 2012-06-01 21:32:11 UTC 
No objections here.
Comment 3 Jean-François Fortin Tam 2013-04-06 15:51:51 UTC 
Created attachment 240848 [details] [review]
proposed patch (untested)

Hi Matthew, would you be kind enough to try this and see if that is the correct fix? I just naïvely checked out the code and made this one-liner, I don't actually have a build of evolution so this is theoretical.
Comment 4 Matthew Barnes 2013-04-09 03:24:51 UTC 
The extra padding looks good, but the info area at the top of the sidebar needs to be the same height or else the misalignment is very noticeable.  Best way to do this is with a GtkSizeGroup, which EShellView used to have.  Not sure why it got removed.

Brought the GtkSizeGroup back here:
https://git.gnome.org/browse/evolution/commit/?id=e17db00f41d85ef48088fd29c2c55f82875682bd

And committed your patch here:
https://git.gnome.org/browse/evolution/commit/?id=23612851212b790717218cb7b065619f2a0c274e

Fixed for Evolution 3.9.1.
Comment 5 Jean-François Fortin Tam 2014-01-11 22:12:54 UTC 
Odd... I'm running Evolution 3.10.3 and I still don't see any spacing above (and below) that area. It pretty much looks identical to the original screenshot.

Matthew, does this work on yours?
Comment 6 Matthew Barnes 2014-01-12 15:50:54 UTC 
It got dropped accidentally as part of bug 709428.  I'll re-add it.