After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 675315 - Cannot immediately right-click on first search result via keyboard
Cannot immediately right-click on first search result via keyboard
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: search
3.24.x
Other Linux
: Normal minor
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-05-02 17:50 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2017-08-17 14:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
viewSelector: Open context for highlighted search result (2.25 KB, patch)
2017-08-15 23:48 UTC, Florian Müllner
committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2012-05-02 17:50:27 UTC
Steps to reproduce:

1. Get into the Overview (Alt+F1)
2. Type a letter
3. Press Shift+F10 to open a context/right-click menu for the selected item

Results: The menu appears but is associated with the search entry.

Workaround: Press Right Arrow, Left Arrow, Shift+F10 and it works as expected.

I'm not sure what the RightAnswer(tm) is. One can make a good case for the existing behavior: You haven't left the search entry and the caret is still visible within that entry. But on the flip side: The first item is selected, pressing Return from the search entry activates the first item, and pressing Tab from the search entry skips over the first item and moves you to the second item. Lastly, the workaround feels odd. <shrugs>

As for why I'm filing it at all, it's potentially confusing for users who are blind.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-05-02 18:01:59 UTC
I knew that having this "fake selection" stuff in the search results would be bad.
Comment 2 Joanmarie Diggs (IRC: joanie) 2012-05-02 18:19:14 UTC
(In reply to comment #1)
> I knew that having this "fake selection" stuff in the search results would be
> bad.

For the record, I didn't say that. :) This is just one of those edge cases.... They happen.

Ya know, a possible solution occurred to me after filing this bug: In the situation described above, make Shift+F10 would apply to the same object as Return.

Rationale (admittedly based on a certain amount of speculation):

* The "typical" user uses the mouse to right-click. These users
  wouldn't notice the change.
* The "typical" keyboard user copies and pastes with Ctrl+C and
  Ctrl+V respectively. For them, the menu that pops up in the
  entry isn't needed.
* It would make the keyboard interaction (Return, Shift+F10) more
  consistent.
* It should solve the problem for users who are blind. :)
Comment 3 Jean-François Fortin Tam 2012-10-29 20:15:46 UTC
Possible dupe of bug #679977 ? Maybe solved in 3.6? I'd need to test for a few weeks/months of "daily use" to be sure...
Comment 4 Allan Day 2013-08-18 14:19:36 UTC
Seems like the context popup should open on the highlighted search result.
Comment 5 Anup 2015-01-21 07:33:51 UTC
Hi,

I am interested in working on this bug. So please can I get assigned for this bug and can anyone help me in fixing this bug?

Regards,
Anup
Comment 6 Anup 2015-01-21 07:38:16 UTC
The bug is still reproducible. So, please can anyone help me with this bug?
Comment 7 André Klapper 2017-08-15 22:57:04 UTC
Still happening in 3.24
Comment 8 Florian Müllner 2017-08-15 23:48:59 UTC
Created attachment 357678 [details] [review]
viewSelector: Open context for highlighted search result

To make search more efficient, users don't need to move the actual
keyboard focus away from the search entry to activate the first
result. However the shift+f10 shortcut to pop up the context menu
via keyboard still acts on the actually focused widget, which is
the entry. It makes more sense to open the context menu of the
selected result instead, as that's what's highlighted and responds
to keyboard activation.
Comment 9 Rui Matos 2017-08-17 13:36:19 UTC
Review of attachment 357678 [details] [review]:

looks fine

::: js/ui/search.js
@@ +688,3 @@
+
+        if (this._defaultResult)
+            this._defaultResult.actor.emit('popup-menu');

st_widget_popup_menu() is public API that could be used instead
Comment 10 Florian Müllner 2017-08-17 14:59:30 UTC
Attachment 357678 [details] pushed as 093b73b - viewSelector: Open context for highlighted search result

Ah yes, indeed - updated patch before pushing.