After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674495 - libbonoboui build for win32 packaging insists on availability of glade
libbonoboui build for win32 packaging insists on availability of glade
Status: RESOLVED FIXED
Product: GnuCash
Classification: Other
Component: Windows
git-master
Other Windows
: Normal normal
: ---
Assigned To: Christian Stimming
Geert Janssens
Depends on:
Blocks:
 
 
Reported: 2012-04-20 20:58 UTC by Mark Jenkins
Modified: 2018-06-29 23:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
alters packaging/win32/libbonoboui-2.24.2.patch to not look for glade and not build libbonoboui-2.24.2/glade (10.19 KB, patch)
2012-04-20 20:58 UTC, Mark Jenkins
committed Details | Review
New version of packaging/win32/libbonoboui-2.24.2.patch in whole form, instead of meta-patch (16.86 KB, application/octet-stream)
2012-04-20 21:08 UTC, Mark Jenkins
  Details

Description Mark Jenkins 2012-04-20 20:58:49 UTC
Created attachment 212457 [details] [review]
alters packaging/win32/libbonoboui-2.24.2.patch to not look for glade and not build libbonoboui-2.24.2/glade

The version of libbonoboui downloaded by packaging/win32/install.sh (libbonoboui-2.24.2) insists on glade existing as a dependency, but building of glade is now disabled in packaging/win32/install.sh .

I tried re-enabling the building of glade prior (prior to libbonobobui) but the glade-3 that it built wasn't being detected by the libbonoboui's configure script either. Tried changing the build process to build an older 2.? glade, but found that had dependancies too.

Decided it was better to just change the gnucash windows build of libbonoboui to not insist on glade seeing how use of glade is only present in the libbonoboui-2.24.2/glade sub directory.

packaging/win32/install-impl.sh already applies the patch packaging/win32/libbonoboui-2.24.2.patch to disable detection of popt in libbonoboui-2.24.2/configure script. I've enhanced libbonoboui-2.24.2.patch even further so that libbonoboui-2.24.2/configure and libbonoboui-2.24.2/Makefile.in no longer deal with the libbonoboui-2.24.2/glade sub directory and no longer attempt glade detection.

To better document this, my version of libbonoboui-2.24.2.patch also patches libbonoboui-2.24.2/configure.in and libbonoboui-2.24.2/Makefile.am to make the same changes so they'd be present in configure and Makefile.in if someone were using libbonoboui-2.24.2.patch and re-running autoconf/automake .

Tested a build of GnuCash on WinXP with this revised libbonoboui patch and in combination with my fix to bug #674494 was able to build GnuCash with install.sh and dist.sh .

This patch can also be applied against the 2.4 branch.
Comment 1 Mark Jenkins 2012-04-20 21:08:26 UTC
Created attachment 212459 [details]
New version of packaging/win32/libbonoboui-2.24.2.patch in whole form, instead of meta-patch

For convienence of readers, this is the complete new version of
libbonoboui-2.24.2.patch . This can be drop-in replaced into the
packaging/win32/ directory by anyone attempting a GnuCash on Windows build.
Comment 2 Christian Stimming 2012-04-22 20:49:16 UTC
Comment on attachment 212457 [details] [review]
alters packaging/win32/libbonoboui-2.24.2.patch to not look for glade and not build libbonoboui-2.24.2/glade

r22156, thanks!
Comment 3 John Ralls 2018-06-29 23:08:23 UTC
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=674495. Please update any external references or bookmarks.