After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674494 - version and method of downloading isocodes in win32 packaging no longer works
version and method of downloading isocodes in win32 packaging no longer works
Status: RESOLVED FIXED
Product: GnuCash
Classification: Other
Component: Windows
git-master
Other Windows
: Normal normal
: ---
Assigned To: Christian Stimming
Geert Janssens
Depends on:
Blocks:
 
 
Reported: 2012-04-20 20:42 UTC by Mark Jenkins
Modified: 2018-06-29 23:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
updates the isocodes download url for win32 packaging (579 bytes, patch)
2012-04-20 20:42 UTC, Mark Jenkins
committed Details | Review
New version of packaging/win32/libbonoboui-2.24.2.patch in whole form (16.86 KB, application/octet-stream)
2012-04-20 21:03 UTC, Mark Jenkins
  Details

Description Mark Jenkins 2012-04-20 20:42:03 UTC
Created attachment 212456 [details] [review]
updates the isocodes download url for win32 packaging

The win32 packaging scripts attempt to download iso-codes-3.18 from:
ftp://pkg-isocodes.alioth.debian.org/pub/pkg-isocodes/

The iso codes project no longer maintains an ftp server at that address. Their downloads are now available at:
http://pkg-isocodes.alioth.debian.org/downloads/

Version 3.18 is also no longer available at that site.

I was able to build and run gnucash using isocodes-3.34 instead. The attached patch (-p0 style) changes packaging/win32/defaults.sh to use the new download site for isocodes and the 3.34 version of it.

Not 100% sure how to test all the places where GnuCash uses this, but I was able to see a functioning list of curriencies in my build.

I looked at the isocodes changelog entries going back to 3.18 and didn't notice any major changes.

Also observed that debian unstable is on isocodes 3.34 and Ubuntu 12.04 is using 3.31, so I presume there are other gnucash users using and testing versions of isocodes greater than 3.18.
Comment 1 Mark Jenkins 2012-04-20 20:44:27 UTC
This patch can also be applied against the 2.4 branch.
Comment 2 Mark Jenkins 2012-04-20 21:03:12 UTC
Created attachment 212458 [details]
New version of packaging/win32/libbonoboui-2.24.2.patch in whole form

For convienence of readers, this is the complete new version of libbonoboui-2.24.2.patch . This can be drop-in replaced into the packaging/win32/ directory by anyone attempting a GnuCash on Windows build.
Comment 3 Mark Jenkins 2012-04-20 21:05:45 UTC
Comment on attachment 212458 [details]
New version of packaging/win32/libbonoboui-2.24.2.patch in whole form

Ooops, sorry, this was intended for bug #674495 .
Comment 4 Mark Jenkins 2012-04-20 21:06:32 UTC
Comment on attachment 212456 [details] [review]
updates the isocodes download url for win32 packaging

It's a patch
Comment 5 Christian Stimming 2012-04-22 20:51:24 UTC
Comment on attachment 212456 [details] [review]
updates the isocodes download url for win32 packaging

r22157, thanks!
Comment 6 John Ralls 2018-06-29 23:08:22 UTC
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=674494. Please update any external references or bookmarks.