After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674437 - media-keys: use the OSD style class
media-keys: use the OSD style class
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: media-keys
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2012-04-19 20:58 UTC by Cosimo Cecchi
Modified: 2012-04-20 09:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
media-keys: use the OSD style class to draw the window (5.03 KB, patch)
2012-04-19 20:58 UTC, Cosimo Cecchi 		committed Details | Review
media-keys: remove unused code (6.67 KB, patch)
2012-04-19 20:58 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2012-04-19 20:58:10 UTC 
This is needed for two reasons:
- now colors of the media keys OSD can be easily customized from the theme, and will be consistent with similar widgets in other applications
- this way, the widget can be shared easily with Totem, (bug 664916) despite it using a dark theme
Comment 1 Cosimo Cecchi 2012-04-19 20:58:11 UTC 
Created attachment 212386 [details] [review]
media-keys: use the OSD style class to draw the window

Now that GTK and Adwaita gained a style class for OSD widgets, use it
when fetching the color values for the media keys window.
Comment 2 Cosimo Cecchi 2012-04-19 20:58:13 UTC 
Created attachment 212387 [details] [review]
media-keys: remove unused code

No need to keep code dealing with color shades in here anymore now.
Comment 3 Bastien Nocera 2012-04-20 09:06:22 UTC 
Attachment 212386 [details] pushed as a0cefe6 - media-keys: use the OSD style class to draw the window
Attachment 212387 [details] pushed as c03d19a - media-keys: remove unused code