After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674178 - fetch korean lyrics from jetlyrics.com
fetch korean lyrics from jetlyrics.com
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Plugins (other)
unspecified
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 674147 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-04-16 06:42 UTC by Jian He
Modified: 2012-10-21 08:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
The JetlyricsParser.py (2.63 KB, text/x-python)
2012-04-16 06:42 UTC, Jian He 		  Details
patch for JlyricParser and JetlyricsParser (8.12 KB, patch)
2012-04-18 02:19 UTC, Jian He 		committed Details | Review

Description Jian He 2012-04-16 06:42:08 UTC 
Created attachment 212116 [details]
The JetlyricsParser.py

A lyrics searcher for jetlyrics.com, for the "Lyrics" plugin.

jetlyrics.com is a korean lyrics site.

There must be two line added in LyricsSites.py:

from JetlyricsParser import JetlyricsParser

lyrics_sites = [
  ...
  { 'id': 'jetlyrics.com', 		'class': JetlyricsParser, 		'name': _("Jetlyrics (jetlyrics.com)") 		},
  ...
]
Comment 1 André Klapper 2012-04-16 07:46:37 UTC 
A patch would be welcome. :) See https://live.gnome.org/Git/Developers#Contributing_patches
Comment 2 Jian He 2012-04-18 02:19:20 UTC 
Created attachment 212247 [details] [review]
patch for JlyricParser and JetlyricsParser

This patch include the japanese lyrics (j-lyric.net) and korean lyrics (jetlyrics.com) Parser.
Comment 3 Jian He 2012-04-18 02:32:02 UTC 
note that the JlyricParser from bug 674147 has been merged into previous patch.
So the previous patch included both japanese lyrics (j-lyric.net) and korean lyrics (jetlyrics.com) Parser.
Comment 4 Jonathan Matthew 2012-10-21 08:34:46 UTC 
*** Bug 674147 has been marked as a duplicate of this bug. ***
Comment 5 Jonathan Matthew 2012-10-21 08:45:16 UTC 
Pushed as commit 14b9e23. Thanks for the patch, and sorry it took so long for me to look at it.
Comment 6 Jonathan Matthew 2012-10-21 08:45:32 UTC 
Review of attachment 212247 [details] [review]:

.