After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674147 - fetch lyrics from j-lyric.net
fetch lyrics from j-lyric.net
Status: RESOLVED DUPLICATE of bug 674178
Product: rhythmbox
Classification: Other
Component: Plugins (other)
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-04-15 17:23 UTC by Jian He
Modified: 2012-10-21 08:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
The parser (2.47 KB, text/x-python)
2012-04-15 17:23 UTC, Jian He 		  Details
patch for LyricsSites.py and Makefile.am (1.61 KB, patch)
2012-04-17 02:59 UTC, Jian He 		none Details | Review

Description Jian He 2012-04-15 17:23:39 UTC 
Created attachment 212090 [details]
The parser

A lyrics searcher for j-lyric.net, for the "Lyrics" plugin.

j-lyric.net is a lyrics site for japanese songs.

There must be two line added in LyricsSites.py:

from JlyricParser import JlyricParser

lyrics_sites = [
  ...
  { 'id': 'j-lyric.net', 		'class': JlyricParser, 		'name': _("Jlyric (j-lyric.net)") 		},
  ...
]
Comment 1 André Klapper 2012-04-15 18:53:17 UTC 
Thanks! Providing this code as a patch is welcome. See https://live.gnome.org/Git/Developers#Contributing_patches
Comment 2 Jian He 2012-04-17 02:59:35 UTC 
Created attachment 212180 [details] [review]
patch for LyricsSites.py and Makefile.am
Comment 3 Jian He 2012-04-17 03:00:29 UTC 
(In reply to comment #1)
> Thanks! Providing this code as a patch is welcome. See
> https://live.gnome.org/Git/Developers#Contributing_patches

The patch for LyricsSites.py and Makefile.am already provided. Thanks!
Comment 4 Jian He 2012-04-18 02:23:08 UTC 
The JlyricParser patch has been merged into the Bug 674178, that patch included the japanese lyrics parser (JlyricParser) and korean lyrics parser (JetlyricsParser) already.
Comment 5 Jonathan Matthew 2012-10-21 08:34:46 UTC 

*** This bug has been marked as a duplicate of bug 674178 ***