GNOME Bugzilla – Bug 673505
Orca speaking twice with bulleted links
Last modified: 2013-12-17 10:19:04 UTC
Created attachment 211296 [details] Debug file with perhaps shows why happening this issue Dear Developers, I experienced now an interesting issue under Ubuntu 12.04, orca master version: If a webpage have bulleted links, Orca double speaking the links. Reproducation steps: 1. Go to http://vakbarat.index.hu webpage. 2. Press l keystroke. 3. Press down arrow ciclical, and navigate the listed links. You will be hear two time the links related informations. I attaching the debug.out file. I think need fixing this issue with 3.4 branch too. Attila
An another example webpage is www.belin.hu. This page containing various lists. Bulleted list of links producing similar issue with http://vakbarat.index.hu webpage. Attila
Duplicate of bug 672464?
Never mind. I see this is not a webkit bug. Sorry for the noise.
José wrote Orca list a simple html code with producing this issue: <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html xmlns="http://www.w3.org/1999/xhtml" lang="pt-BR" xml:lang="pt-BR"> <body> <ul> <li><a href="http://www.brasil.gov.br" title="Link externo: Portal de Estado do Brasil">Brasil</a></li> <li><a href="http://www.brasil.gov.br" title="Link externo: Portal de Estado do Brasil">France</a></li> </ul> </body> </html> Attila
(In reply to comment #3) > Never mind. I see this is not a webkit bug. Sorry for the noise. I have analyzed this issue and fixed...Shall i upload the patch for your comments if it is not yet solved?
Yes please. You what Orca version fixed this issue? You working with master branch when created the fix? Attila
(In reply to comment #6) > Yes please. You what Orca version fixed this issue? You working with master > branch when created the fix? > > Attila Attached the patch. I am working on 3.9.3 version,so tested in that.Created the patch from origin/gnome-3-8 branch. Kindly check and let me know....
Created attachment 257822 [details] [review] [patch] Attached the patch for fixing bug 673505
Hi Jansi, Well, now only I have possibility to test your patch with Ubuntu 12.04 awailable Orca 3.4.2 version (the test is done). The http://vakbarat.index.hu webpage the issue is resolved your patch, but unfortunately the http://belin.hu webpage not. I created an index.html with following code the Libreoffice Writer: <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN"> <HTML> <HEAD> <META HTTP-EQUIV="CONTENT-TYPE" CONTENT="text/html; charset=utf-8"> <TITLE></TITLE> <META NAME="GENERATOR" CONTENT="LibreOffice 4.1.1.2 (Linux)"> <META NAME="AUTHOR" CONTENT="Hammer Attila"> <META NAME="CREATED" CONTENT="20131022;113641196526278"> <META NAME="CHANGEDBY" CONTENT="Hammer Attila"> <META NAME="CHANGED" CONTENT="20131022;113847874487709"> <STYLE TYPE="text/css"> <!-- @page { margin: 2cm } P { margin-bottom: 0.21cm } A:link { so-language: zxx } --> </STYLE> </HEAD> <BODY LANG="hu-HU" DIR="LTR"> <UL STYLE="margin-left: 0.64cm"> <LI><P STYLE="margin-bottom: 0cm"><A HREF="blabla.html">Blabla</A></P> <LI><P STYLE="margin-bottom: 0cm"><A HREF="blabla2.html">blabla2</A></P> </UL> </BODY> </HTML> I will be attaching this index.html file. When you testing this local html, do following: 1. Launch firefox, and open index.html. 2. Press l keystroke to jump the list. 3. Press down arrow and up arrow keystrokes. Both two situation you will be hear duplicated the link texts. I think this situation the problem is following: Libreoffice when I created the bulleted list automaticaly put the <P STYLE="margin-bottom: 0cm"> tag before links. When I removed this tag the bulleted list, your patch works gracefuly. Attila
Created attachment 257829 [details] Bad index.html with still producing the reported issue
Created attachment 257838 [details] [review] Updated patch Updated Patch after fixing the issue which arises on index.html.. Please Check and let me know.
Jansi, I tested the updated patch (Orca 3.4.2 version with my Ubuntu 12.04 system). If I opening the index.html file and press a simple TAB key, Orca not spokened me the selected link. Reproducation steps: 1. Open the index.html. 2. Press l keystroke. 3. Press TAB key. This situation I not hear the next link with have a bulleted list. Another testcase: 1. Open index.html file. 2. Press TAB key. This situation I not hear the first link in the bulleted list. The previous comment I wrote issue resolved the updated patch. Can you experiencing similar issue with Orca 3.8 or the master version? Attila
Created attachment 257892 [details] [review] patch fixing 3 issues reported Thank You for this quick and detailed testing. Have updated the patch. Hope this patch solve the problems. Kindly test and let me know.
Please provide feedback about this patch, Whether it is acceptable? Thanks, P. Jansi Rani
Hi Jansi, Sorry the long response, yesterday I am not in home. I will look your patch this day and report back you the results. Attila
Created attachment 257989 [details] [review] Final patch Hi Jansi, Many thanks the updated patch. Your last fix basicaly good, but unfortunately when I using SHIFT+TAB keystroke, Orca doesn't spokened me the previous link. Reproducation steps: 1. Open index.html file. 2. Press l keystroke. 3. Press DOWN arrow. 4. Press SHIFT+TAB keystroke. Orca will not announce the previous link. I doed a joined patch with containing all you doed fixes this bug related, and little modifyed your if statement. You used following part: and not (orca_state.lastInputEvent.event_string == "Tab") Because I not want writing separate variations (ISO_Right_Tab, ISO_Left_Tab and Tab keys), I modifi little this part with following sintax: and not (orca_state.lastInputEvent.event_string.__contains__("Tab")) This modification handles all possible cases when the user using the Tab key any key combinations in a bulleted list with containing links. Joanie, I think we ready this bug fix. Can you final reviewing this patch? I tested now only the fix with Orca 3.4.2 version my Ubuntu 12.04 system, but this day I will be testing the last patch with Saucy. I not founded any other problems the final fix related. Jansi, some possible useful hints if you future creating git diffs: If you doing fixes, create a local branch with your orca source directory with following command, example this bug report: git branch 673505 If you want switching this branch, use git checkout 673505 command. Once need configuring your git user.name and user.email variables with following commands: git config user.name "your name" git config user.email "your email address" I think this variables are branch independent. This is interesting only if an Orca developer committing your fix. Your name and e-mail address will be presenting the commit message if a developer direct committing your patch. Now, following seeing your patches: From: root <root@pjansirani.chennai.cdac.in> You working root account your system? If you final ready a fix and the fix is good, you easy to possible doing an Orca master branch compatible patch with following command: git format-patch master Be carefuly you alvays merge the final fix with previous doed modifications. Now, when I tested your final fix, I need apply three patches (your first fix, your first updated fix and your last updated fix). I doed previous this typical mistake too before Joanie not tells me some hints. :-):-) Attila
Hi, Thank You so much for making the fix much better and also sorry regarding shift+Tab functionality. Your solution generalizes that tabs. Git: Many thanks for git commands,hereafter surely i will follow these. :) I am working on "root" account only.:)... Thanks, P. Jansi Rani
Hi Joanie and Jansi, I have got a good news: the last fix works perfectly with Orca master branch version. Testing environment: Ubuntu Saucy, latest git master branch of Orca and Firefox builtin actual version. I not experienced any problems when tested with index.html file. Joanie, if passed this patch the final review, please commit this last patch the master branch. If fit this fix with Orca 3.10 branch, please commit this fix into Orca gnome-3-10 branch too. Jansi, thank you your work to fix this bug. Attila
I'm not convinced that this bug is limited to just links in list items, nor am I convinced that tab-related keys are the only scenario where we want to ignore the event. In fact, my gut tells me that this approach is going to add regressions which you haven't discovered yet. So.... What I suggest is that you keep using that patch for a while and see what else breaks.
Oops, I meant: that tab-related keys are the only scenario where we want to *not* ignore the event.
Ok, this is right, need more testing and wait the results. Normal homepages with not containing lists I not experienced problems yet with links related. Example homepage: http://www.origo.hu/hirmondo An example bulleted list have links containing webpage is http://vakbarat.index.hu. The patch works good with this homepage.some links) Reproducation steps to test drastical the patch: 1. Goto http://vakbarat.index.hu. 2. Press l keystroke. 3. Press some down arrow keys in the list and use SHIFT+TAB keystroke. Orca jumps correct the previous link, so this is the expected result I think. I tryed this test with up arrow keystroke, i keystroke in the list, arrow keys, tab key combinations producing the good result. Attila
Hi Joanie and Attila, Thanks for your support. Till now i didn't face any issues with that patch. If you have identified anything kindly inform. Please let me know, when it can be possible to be uploaded with the branch if it is accepted. Also, along with your assistance shall i analyze any other defect? Thanks, P. Jansi Rani
If you have time to work other bugs, yes please. Attila
If the issue 523351 not yet resolved shall i work on that? Thanks, P. Jansi Rani
Any updates regarding this??? Kindly let me know status. Thanks, P. Jansi Rani
Comment on attachment 257989 [details] [review] Final patch I'm afraid this is a non-performant hack that fails to address the real problem, namely that what should the locus of focus is not the locus of focus.
Assigning to myself.
(In reply to comment #26) > (From update of attachment 257989 [details] [review]) > I'm afraid this is a non-performant hack that fails to address the real > problem, namely that what should the locus of focus is not the locus of focus. Hi Joanie, I just want to understand how this patch fails to address to real problem, so that i will correct that in the future bugs which i ll be fixing. Problem: Orca speaking twice with bulleted links. Reason : Announcement of bullet identification happened in 2 places, 1. List presentation, 2. On Focus. Solution: Prompting of bullets not required on focus event that needs to be eliminated. So, have added an condition that checks both the situations that is,event.source obj and locusoffocus obj for the links. If so, return from the event without prompting anything. Please let me know which one i understood wrongly.... Thanks, P. Jansi Rani
Hi Joanie, Any updates regarding above comment.. Kindly let me know the issue leads to the patch rejection. Thanks, P. Jansi Rani
Hi, Any updates on this? Thanks, P. Jansi Rani
Attila, could you please verify that this bug no longer exists in master? Thanks!
(In reply to comment #31) > Attila, could you please verify that this bug no longer exists in master? > Thanks! I can confirm that this bug is not present in orca master. I can reproduce the bug using orca 3.10 but I can not reproduce the bug using orca master.
I confirming with José wrote. This bug is not existing with Master branch latest version. I tested this my local testing html file and http://vakbarat.index.hu webpage. Only interesting situation for example with http://vakbarat.index.hu webpage when I using l to jump the list, if arrow key moving Orca doesn't presenting bulleted list simbol character. Same the result with I and i structural navigation command, and l or L structural navigation command if jumps the next list. Attila
The list symbol is a known (and separate) issue. Closing this bug as FIXED -- and happily done by removing hacks and making Orca more performant. Thanks for the report and testing.
Created attachment 264393 [details] Debug file for Firefox 25.0 related I reopened this bug, unfortunately this bug come back, I don't no why. Testcase with I reproduced the bug both Firefox 25.0 and latest Firefox 27.0 beta nightly build with fixed the lists related bug: 1. Launch Firefox, and goto http://vakbarat.index.hu website. 2. Press l keystroke. You will be hear twice the "belföld" link. 3. Press down arrow key few times, and up arrow key. Every key press you will be hear twice the bulleted links. Firefox 25.0 of course Orca will not spokening the bulleted list simbol, this is fixed with latest Firefox 27.0 beta and Firefox 29 development build. Both tests I used Orca master branch version my Ubuntu 14.04 development environment. Attila
Created attachment 264394 [details] Debug file for 27.0 related
I am not seeing this issue. In addition, are you *sure* you are using Orca from master? The reason I ask is because I see the following in your debug.out files: 1. The event manager registering listeners for each and every script. In Orca master the event manager registers only a single set of listeners. 2. The use of the CALLY script. In Orca master there is no longer a CALLY script; there is a clutter script. This suggests that if you are using Orca master, you are using a version before I fixed the bug. Alternatively, you are not using Orca master and/or you have a mixed environment because you did not remove the installed 3.10.x version of Orca and/or did not do a git clean -fxd. Could you please try to reproduce the problem being sure that you are using Orca master? Thanks.
Hi Joanie, You are true. I temporary previous week switch gnome-3-10 branch when I verifyed a hungarian translation update for Orca, but I forgot to switch back master branch and recompile Orca master branch version. Now I switch back Orca master branch. Before git check master command I doed an uninstall and removed /usr/lib/python3.3/site-packages/orca directory. I verifyed now with Orca master branch version the issue again. The issue is not happening, except Orca master branch version not spokening yet the list simbol character in Firefox 27.0 nightly build. Attila
Ok, this is not my day. I not closed all Firefox window when I experienced the list simbol related issue. Possible launched an old Firefox 25.0 window previous with I forgot to close before I testing the issue in Firefox 27.0 with Orca master branch version. Everithing works correct now in Firefox 27.0. :-):-) Attila