After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673286 - [PATCH] gtk-doc scanner can't scan uninstalled gstreamer
[PATCH] gtk-doc scanner can't scan uninstalled gstreamer
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Windows
: Normal minor
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 673844
Blocks:
 
 
Reported: 2012-04-01 08:44 UTC by LRN
Modified: 2012-08-07 08:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Define GTKDOC_RUN to be used in common (1.26 KB, patch)
2012-04-01 08:46 UTC, LRN
none Details | Review
Uses GTKDOC_RUN to specify RUN envvar for gtk-doc (851 bytes, patch)
2012-04-01 08:47 UTC, LRN
none Details | Review
Define GTKDOC_RUN to be used in common (-base) (1.38 KB, patch)
2012-04-02 04:00 UTC, LRN
none Details | Review
Define GTKDOC_RUN to be used in common (core) (1.26 KB, patch)
2012-04-10 13:46 UTC, LRN
none Details | Review
Define GTKDOC_RUN to be used in common (core) (1.38 KB, patch)
2012-04-10 14:45 UTC, LRN
none Details | Review
Define GTKDOC_RUN to be used in common (-base) (1.76 KB, patch)
2012-04-10 16:58 UTC, LRN
none Details | Review
Define GTKDOC_RUN to be used in common (-base) (1.67 KB, patch)
2012-04-14 01:32 UTC, LRN
rejected Details | Review
Add proper libraries to GST_LIBS instead (1.21 KB, patch)
2012-08-06 13:12 UTC, LRN
committed Details | Review
Add proper libraries to GST_LIBS instead (-base) (965 bytes, patch)
2012-08-06 13:50 UTC, LRN
committed Details | Review

Description LRN 2012-04-01 08:44:05 UTC
docs/gst/$(DOC_MODULE)-scan program tries to open a plugin, which depends on libgstbase. Because gstreamer it not installed yet, it fails (displays a pop-up window with an error message).
Comment 1 LRN 2012-04-01 08:46:31 UTC
Created attachment 211065 [details] [review]
Define GTKDOC_RUN to be used in common

Uses libtool --mode=execute to run the scanner, telling libtool to add directories of the shared libraries to its PATH before running it.

GTKDOC_RUN is used in common (see the other patch)
Comment 2 LRN 2012-04-01 08:47:05 UTC
Created attachment 211066 [details] [review]
Uses GTKDOC_RUN to specify RUN envvar for gtk-doc
Comment 3 LRN 2012-04-02 04:00:36 UTC
Created attachment 211101 [details] [review]
Define GTKDOC_RUN to be used in common (-base)

Uses libtool --mode=execute to run the scanner, telling libtool to add
directories of the shared libraries to its PATH before running it.

GTKDOC_RUN is used in common (see the other patch)
Comment 4 LRN 2012-04-02 04:01:34 UTC
To clarify: attachment 211101 [details] [review] is for -base, attachment 211065 [details] [review] is for core.
Comment 5 LRN 2012-04-10 13:46:00 UTC
Created attachment 211738 [details] [review]
Define GTKDOC_RUN to be used in common (core)

Updated the patch to work with current git master core. Probably should have used some kind of variable instead of "1.0" (the way it's done for -base; but then, i haven't tried to compile -base yet, maybe it requires patching too...)
Comment 6 LRN 2012-04-10 14:45:45 UTC
Created attachment 211742 [details] [review]
Define GTKDOC_RUN to be used in common (core)

This version uses @GST_API_VERSION@ instead of hard-coded 1.0
Comment 7 LRN 2012-04-10 16:58:03 UTC
Created attachment 211779 [details] [review]
Define GTKDOC_RUN to be used in common (-base)

Uses @GST_API_VERSION@ instead of @GST_MAJORMINOR@
Comment 8 LRN 2012-04-14 01:32:12 UTC
Created attachment 212028 [details] [review]
Define GTKDOC_RUN to be used in common (-base)

Same as before, but without libgstinterfaces, which was removed in http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=69b18ab09d01c6baa37e502887a5fd7e93892f54
Comment 9 Tim-Philipp Müller 2012-05-25 08:19:27 UTC
Out of curiosity, is it enough to just add these .la to GTKDOC_LIBS ?
Comment 10 LRN 2012-05-28 12:56:39 UTC
No idea.
If GTKDOC_LIBS is for linking, then that's not going to work, because it'll just do dynamic linking (it does anyway?), and then it will still need .dll files to run.
Comment 11 Tim-Philipp Müller 2012-05-28 13:13:32 UTC
> No idea.
> If GTKDOC_LIBS is for linking, then that's not going to work, because it'll
> just do dynamic linking (it does anyway?), and then it will still need .dll
> files to run.

Yes, but if I'm not mistaken libtool should in that case ensure that the local .DLLs from the build tree are found and used.
Comment 12 Tim-Philipp Müller 2012-06-26 23:09:49 UTC
LRN: ping?
Comment 13 LRN 2012-08-06 13:12:09 UTC
Created attachment 220436 [details] [review]
Add proper libraries to GST_LIBS instead

Tim, you were right.
Comment 14 LRN 2012-08-06 13:50:33 UTC
Created attachment 220441 [details] [review]
Add proper libraries to GST_LIBS instead (-base)

-base version of the above
Comment 15 Sebastian Dröge (slomo) 2012-08-07 08:43:30 UTC
commit f8858297300c8787edd5f42de8883ff3c5295c71
Author: Руслан Ижбулатов <lrn1986@gmail.com>
Date:   Mon Aug 6 17:28:06 2012 +0400

    docs: Add proper libraries to GST_LIBS instead (-base)


commit 2ec1ac8af03cc7f660b4242389c2a8d4a476f96a
Author: Руслан Ижбулатов <lrn1986@gmail.com>
Date:   Mon Aug 6 16:33:57 2012 +0400

    docs: Make sure scanner gets required libraries