GNOME Bugzilla – Bug 672574
webapps: use 'Internet' category rather than 'Other'
Last modified: 2015-10-07 13:35:54 UTC
It feels more appropriate to use the existing 'Internet' category for web app launchers, rather than the current 'Other'. (putting my general dislike for system given categorization aside).
Makes sense to me. I suppose 'Other' was chosen because this is not bundled with the system. Although it would make sense for the user to look for his/her *web* application in Internet category, or close to those applications.
Created attachment 210765 [details] [review] e-web-app-utils: use Categories in desktop file
Created attachment 210767 [details] [review] e-web-app-utils: move to lib/
Created attachment 210768 [details] [review] e-web-app-utils: add ephy_web_application_get_desktop_file Returns the absolute path to the application .desktop file.
Created attachment 210769 [details] [review] e-profile-migrator: update web-apps .desktop files Category
Review of attachment 210767 [details] [review]: So, this already happened in git master.
Review of attachment 210768 [details] [review]: I added the destkop file name to EphyWebApplication, seems simpler than this (and the API is private anyway so I think it's OK).
(In reply to comment #2) > Created an attachment (id=210765) [details] [review] > e-web-app-utils: use Categories in desktop file Someone is now proposing we use a special category for Web Applications, see bug #676035. Not sure what makes more sense, to be honest.
*** Bug 708425 has been marked as a duplicate of this bug. ***
Created attachment 265713 [details] [review] e-profile-migrator: update web-apps .desktop files Category
*** Bug 676035 has been marked as a duplicate of this bug. ***
(In reply to Xan Lopez from comment #8) > Someone is now proposing we use a special category for Web Applications, see > bug #676035. Not sure what makes more sense, to be honest. At the time the special category was a requirement in order to get the web apps to show up separately in GNOME Shell. That didn't happen and nowadays we don't show categories anymore, so there is no value in using a special category, as categories only matter for third-party desktops, which will not look at the special category. So the Internet category makes more sense now.
Review of attachment 210765 [details] [review]: We'll need to rebase this :(
Review of attachment 210765 [details] [review]: Ah, it's just the file moved to lib, that's all.
Review of attachment 265713 [details] [review]: ::: lib/ephy-profile-migrator.c @@ +1004,3 @@ migrate_new_urls_table, migrate_form_passwords_to_libsecret, + migrate_app_desktop_files, Here it would be good to use a more specific function name, migrate_app_desktop_file_categories, since we may well need other migrations here in the future.
Tested, still works, pushed with the one function renamed as suggested. Attachment 210765 [details] pushed as b1b30a3 - e-web-app-utils: use Categories in desktop file Attachment 265713 [details] pushed as 9fddd07 - e-profile-migrator: update web-apps .desktop files Category