After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672001 - build: Drop gettext configure rules as it conflicts with intltool
build: Drop gettext configure rules as it conflicts with intltool
Status: RESOLVED FIXED
Product: gnome-system-log
Classification: Core
Component: general
3.3.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-system-log-maint
gnome-system-log-maint
Depends on:
Blocks:
 
 
Reported: 2012-03-13 16:05 UTC by Jeremy Bicha
Modified: 2013-08-27 14:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Drop gettext configure rules as it conflicts with intltool (883 bytes, patch)
2012-03-13 16:05 UTC, Jeremy Bicha 		committed Details | Review
Patch to fix build (983 bytes, patch)
2013-08-26 21:58 UTC, Seán de Búrca 		committed Details | Review

Description Jeremy Bicha 2012-03-13 16:05:02 UTC 
Without this patch, reconfiguring won't work as intltool stops the build if it detects po/Makefile.in.in that was modified by something else.
    
See https://bugzilla.gnome.org/627789 for more info.
Comment 1 Jeremy Bicha 2012-03-13 16:05:59 UTC 
Created attachment 209616 [details] [review]
build: Drop gettext configure rules as it conflicts with intltool

Without this patch, reconfiguring won't work as intltool stops the build
if it detects po/Makefile.in.in that was modified by something else.

See https://bugzilla.gnome.org/627789 for more info.
Comment 2 Cosimo Cecchi 2012-03-21 14:50:36 UTC 
Review of attachment 209616 [details] [review]:

Thanks, looks good to push after the freeze.
Comment 3 André Klapper 2012-06-26 12:18:07 UTC 
jbicha: gnome-system-log has branched for gnome-3-4 so can you please commit the patch?
Comment 4 Cosimo Cecchi 2012-06-28 20:52:49 UTC 
Attachment 209616 [details] pushed as aa0ad83 - build: Drop gettext configure rules as it conflicts with intltool

Pushed now.
Comment 5 Cosimo Cecchi 2012-06-29 01:33:46 UTC 
I reverted this, as it breaks running autogen.sh on a clean git checkout.
Comment 6 Jeremy Bicha 2012-06-29 02:08:22 UTC 
Cosimo, I just tested the patch and running autogen.sh worked fine after I created an empty directory named m4.
Comment 7 Cosimo Cecchi 2012-06-29 16:52:53 UTC 
Yeah, it shouldn't be needed to create that directory manually, and putting back the macro avoids that.
On the other hand, I see that macro is used in a number of other modules, why is this a problem only for gnome-system-log?
Comment 8 Seán de Búrca 2013-08-26 21:58:10 UTC 
Created attachment 253192 [details] [review]
Patch to fix build

The problem may be that ACLOCAL_AMFLAGS is pulled in by autogen. The patch I am attaching addresses the original issue and should automatically create the m4 directory.
Comment 9 David King 2013-08-27 14:37:03 UTC 
Review of attachment 253192 [details] [review]:

The change looks fine to me (as a gnome-common maintainer), but you might want to split the commit message so that it has a one-line (less than 72 characters) message, then a blank line, then the remainder of the message. Also, please link to this bug in the commit message before pushing.