GNOME Bugzilla – Bug 671402
Doesn't compile with -Werror=deprecated-declarations
Last modified: 2012-03-10 15:27:02 UTC
Created attachment 209020 [details] [review] Partial fix Eog doesn't compile with this flag. One issue remaining: GtkStyle should be changed to GtkStyleContext, however I have no idea how to do it.
Review of attachment 209020 [details] [review]: I guess the GtkStyle issue is the style override in EogWindow when entering fullscreen mode. It appears the problem this code solved (bug #425613) went away when we removed EogScrollView's parent-GtkFrame (bug 614807) in 2.32. The GtkPaned which is now the parent of the ScrollView doesn't react to the padding style properties (contrary to GtkFrame) which are apparently the replacement for [xy]thickness. So, that code can likely go away, considering it does nothing right now as gtk_widget_set_style is a NOOP in gtk3. ::: src/eog-scroll-view.c @@ +1683,3 @@ + device_manager = gdk_display_get_device_manager (gtk_widget_get_display (widget)); + device = gdk_device_manager_get_client_pointer (device_manager); + gdk_window_get_device_position (gtk_widget_get_window (GTK_WIDGET (priv->display)), device, &x, &y, &mods); This one could probably use the device from the motion event and thus save the detour through GdkDeviceManager. Also, we don't seem to need the modifiers there.
Pushed with modifications, taking the blame for the GtkStyle-matter if it breaks. :) I am getting no deprecation warnings anymore during building now, so I hope it's fixed for you too (my GCC doesn't support that flag yet it seems). Please re-open this bug if it does for eog-3.3.x/3.4.x. Thanks! commit f9a5ec6522b616421f1f2d5d41f77c3c6ab788bd Author: Felix Riemann <> Date: Sat Mar 10 15:14:33 2012 +0100 Remove deprecated, unneeded and now effect-less GtkStyle-usage This stuff wasn't needed anymore since we dropped the GtkFrame as parent for the EogScrollView widget. Also it didn't have any effect at all in GTK+-3. Fixes more build warnings because of deprecations. https://bugzilla.gnome.org/show_bug.cgi?id=671402 commit c87818df0fe3ea5a5783426011925d2e2e752b24 Author: Adrian Zgorzałek <> Date: Wed Feb 29 22:08:31 2012 +0100 Fix GDK deprecations Partially fixes compiling with -Werror-deprecated. http://bugzilla.gnome.org/show_bug.cgi?id=671402 --- This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Actually flag I mentioned earlier doesn't exist :-) It compiles fine with exisiting one.