Created attachment 86464 [details] [review]
Proposed fix

This patch makes the frame where view is put available through priv->frame so you can gtk_widget_reparent() view on eog_window_{run|stop}_fullscreen ().

I'm just reparent'ing  the view widget from frame to layout on run|stop_fullscreen.

Comments :)?

A forgot to say that eog_window_collection_mode_changed_cb () would need a s/frame/priv->frame/g and removing GtkWidget *frame.
:)

Hm, I was about to commit it, but now that I think, if we hide the frame, then we don't need to change its "shadow-type", right?

If possible update with the changes that you commented, too.

Created attachment 86728 [details] [review]
Updated patch.

Looks like my old gtk+ didn't complain about the gtk_widget_reparent() to a container that already had a child.
I had to use gtk_container_remove() and g_object_{ref|unref}().

Anyway, the updated patch :).

It updates the eog_window_collection_mode_changed_cb () function too.

ping :)

Created attachment 90386 [details] [review]
another idea

Well, this is another idea I had to solve this.
It simply sets the border width of the frame to 0.
I am not sure if it is fully correct and sane though (as I don't fully understand the GtkStyle system), but it worked on my box at least.

Raising severity, this is a major issue since it unnecessarily scales images to a smaller size.

Setting the style is much saner than re-parenting. Actually, it's the correct way. :-) Thanks guys!

2007-06-22  Lucas Rocha  <lucasr@gnome.org>
                
        * src/eog-window.c (eog_window_run_fullscreen,
        eog_window_stop_fullscreen): removed grey border when in fullscreen
        mode. Fixes bug #425613 (Felix Riemann).