After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670579 - Generate warning when action is hard-coded too
Generate warning when action is hard-coded too
Status: RESOLVED OBSOLETE
Product: gnome-control-center
Classification: Core
Component: Keyboard
3.2.x
Other Linux
: Normal minor
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
3.10
: 681969 689236 690154 707894 732282 771124 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-02-22 04:50 UTC by Serhiy Zahoriya
Modified: 2021-06-09 16:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
keyboard: Build scaffolding for hard-coded shortcut conflicts (13.99 KB, patch)
2016-09-09 15:41 UTC, Bastien Nocera
none Details | Review
keyboard: Error when new shortcut conflicts with system shortcut (4.11 KB, patch)
2016-09-09 15:41 UTC, Bastien Nocera
none Details | Review
keyboard: Build scaffolding for hard-coded shortcut conflicts (13.89 KB, patch)
2018-01-30 10:52 UTC, Bastien Nocera
none Details | Review
keyboard: Error when new shortcut conflicts with system shortcut (4.03 KB, patch)
2018-01-30 10:52 UTC, Bastien Nocera
none Details | Review
keyboard: Error when new shortcut conflicts with system shortcut (3.77 KB, patch)
2018-01-30 17:15 UTC, Bastien Nocera
none Details | Review

Description Serhiy Zahoriya 2012-02-22 04:50:41 UTC
Steps to reproduce:
1. Launch gnome-control-center
2. Go to Keyboard - Shortcuts - Custom shortcuts
3. Add any command and set XF86ScreenSaver as shortcut button
4. Press XF86ScreenSaver

Expected result:
Custom command being run.

Actual result:
Custom command runs and the session is being locked.
Comment 1 Bastien Nocera 2012-02-23 12:05:49 UTC
The button's use is hardcoded:
http://git.gnome.org/browse/gnome-settings-daemon/tree/plugins/media-keys/shortcuts-list.h#n108

And we don't have support in gnome-control-center for detecting those hard-coded actions. We should warn when the user tries to override them.
Comment 2 Tomáš Hnyk 2012-05-24 11:20:06 UTC
This seems to be a duplicate of https://bugzilla.gnome.org/show_bug.cgi?id=660566
Comment 3 Bastien Nocera 2013-04-24 10:20:57 UTC
*** Bug 690154 has been marked as a duplicate of this bug. ***
Comment 4 Stephen 2013-04-25 08:19:33 UTC
From bug 690154:

The sleep button on the keyboard (XF86Sleep -- keycode 150) cannot be reassigned by the gnome-control-center GUI.  

This is because the power buttons on the computer (including
those on the keyboard) are controlled by the following dconf settings:
org.gnome.settings-daemon.plugins.power    button-hibernate
org.gnome.settings-daemon.plugins.power    button-power
org.gnome.settings-daemon.plugins.power    button-sleep
org.gnome.settings-daemon.plugins.power    button-suspend

The gnome-control-center GUI doesn't know about or manage these settings.

The keyboard sleep button is annoyingly easy to press by mistake, making the computer suddenly sleep without any warning.    I can re-assign the button using the gnome-control-center GUI after I use dconf-editor to set button-hibernate, button-sleep, and button-suspend to 'nothing'.

My preference would be for the sleep button (on the keyboard) to be able to be re-assigned (rather than a warning message saying that it can't).
Comment 5 Bastien Nocera 2013-04-25 08:24:26 UTC
(In reply to comment #4)
> From bug 690154:
<snip>
> My preference would be for the sleep button (on the keyboard) to be able to be
> re-assigned (rather than a warning message saying that it can't).

I've said in the other bug that this wouldn't happen. Please keep this bug on topic.
Comment 6 Stephen 2013-04-25 08:25:02 UTC
This bug's title is not very descriptive.  Can somebody who can edit it please change it to:

Keyboard buttons with special purpose should not be assignable via Gnome Control Center GUI -- generate a warning dialog
Comment 7 Bastien Nocera 2014-07-15 15:22:23 UTC
*** Bug 732282 has been marked as a duplicate of this bug. ***
Comment 8 Bastien Nocera 2015-07-10 16:11:54 UTC
*** Bug 707894 has been marked as a duplicate of this bug. ***
Comment 9 Bastien Nocera 2016-09-08 15:52:19 UTC
*** Bug 689236 has been marked as a duplicate of this bug. ***
Comment 10 Bastien Nocera 2016-09-09 15:41:16 UTC
*** Bug 771124 has been marked as a duplicate of this bug. ***
Comment 11 Bastien Nocera 2016-09-09 15:41:45 UTC
Created attachment 335205 [details] [review]
keyboard: Build scaffolding for hard-coded shortcut conflicts
Comment 12 Bastien Nocera 2016-09-09 15:41:52 UTC
Created attachment 335206 [details] [review]
keyboard: Error when new shortcut conflicts with system shortcut

FIXME the label doesn't disappear, and this doesn't work in the custom
shortcut dialogue.
Comment 13 Bastien Nocera 2017-06-20 09:37:07 UTC
*** Bug 681969 has been marked as a duplicate of this bug. ***
Comment 14 Georges Basile Stavracas Neto 2018-01-26 22:03:56 UTC
These patches are not applying on master.
Comment 15 Bastien Nocera 2018-01-30 10:52:23 UTC
Created attachment 367631 [details] [review]
keyboard: Build scaffolding for hard-coded shortcut conflicts
Comment 16 Bastien Nocera 2018-01-30 10:52:28 UTC
Created attachment 367632 [details] [review]
keyboard: Error when new shortcut conflicts with system shortcut

FIXME the label doesn't disappear, and this doesn't work in the custom
shortcut dialogue.
Comment 17 Bastien Nocera 2018-01-30 17:15:21 UTC
Created attachment 367652 [details] [review]
keyboard: Error when new shortcut conflicts with system shortcut

FIXME the label doesn't disappear, and this doesn't work in the custom
shortcut dialogue.
Comment 18 André Klapper 2021-06-09 16:33:26 UTC
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version, then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a new bug report at
  https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/

Thank you for your understanding and your help.