After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669626 - [PATCH] Stop using deprecated GtkTable
[PATCH] Stop using deprecated GtkTable
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Online Accounts
git master
Other Linux
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
Control-Center Maintainers
Depends on: 669625
Blocks:
 
 
Reported: 2012-02-08 02:48 UTC by Robert Ancell
Modified: 2012-06-19 15:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Replace deprecated GtkTable with GtkGrid (GOA code must continue to use GtkTable until GOA is updated) (1.94 KB, patch)
2012-02-08 02:48 UTC, Robert Ancell 		committed Details | Review
Replace remaining deprecated GtkTable with GtkGrid (speculating on new GOA API which is not yet defined) (2.08 KB, patch)
2012-02-08 02:49 UTC, Robert Ancell 		none Details | Review

Description Robert Ancell 2012-02-08 02:48:59 UTC 
Created attachment 207048 [details] [review]
Replace deprecated GtkTable with GtkGrid (GOA code must continue to use GtkTable until GOA is updated)

Stop using deprecated GtkTable and use GtkGrid.  This is done in two patches as GOA needs to be updated to support GtkGrid (bug 669625)
Comment 1 Robert Ancell 2012-02-08 02:49:19 UTC 
Created attachment 207049 [details] [review]
Replace remaining deprecated GtkTable with GtkGrid (speculating on new GOA API which is not yet defined)
Comment 2 Bastien Nocera 2012-02-08 12:05:17 UTC 
Where's the GOA bug?
Comment 3 Robert Ancell 2012-02-08 22:12:48 UTC 
bug 669625
Comment 4 Bastien Nocera 2012-06-19 13:49:44 UTC 
Rishi, does this apply and work?
Comment 5 Debarshi Ray 2012-06-19 15:07:15 UTC 
(In reply to comment #4)
> Rishi, does this apply and work?

Robert's 2nd patch is no longer needed. See:

commit 3ae795ea6ec09c8a1d49533510904dec9425f617
Author: Debarshi Ray <debarshir@gnome.org>
Date:   Sat Apr 14 23:10:37 2012 +0200

    online-accounts: goa_provider_show_account now expects GtkGrids, not GtkTable
    
    Fixes: https://bugzilla.gnome.org/669625

This was fixed when GtkTable was removed from GOA, else gnome-control-center builds would fail.
Comment 6 Bastien Nocera 2012-06-19 15:11:42 UTC 
Comment on attachment 207049 [details] [review]
Replace remaining deprecated GtkTable with GtkGrid (speculating on new GOA API which is not yet defined)

Marking  as obsolete as it's not needed anymore.
Comment 7 Bastien Nocera 2012-06-19 15:12:41 UTC 
No more patches to commit. Thanks Robert and Rishi.