GNOME Bugzilla – Bug 669625
Support GtkGrid
Last modified: 2013-05-18 09:27:21 UTC
GtkTable has been deprecated the GOA API needs to support the replacement, GtkGrid.
I had a quick look at what needs to be done for this, I guess there needs to be new API to make it work? void (*show_account_in_grid) (GoaProvider *provider, GoaClient *client, GoaObject *object, GtkBox *vbox, GtkGrid *grid); goa_provider_show_account_in_grid (GoaProvider *provider, GoaClient *client, GoaObject *object, GtkBox *vbox, GtkGrid *grid); GtkWidget *goa_util_add_heading_in_grid (GtkGrid *grid, const gchar *heading_text); etc. The other option is to change the GtkTable parameters to GtkWidget and handle internally if they are Tables or Grids. What method do you recommend?
I am quite happy with the first approach. ie. changing the GtkTable* parameters to GtkGrid*. The problem that I ran into was the way the providers actually add widgets to the tables. They use these goa_util_* methods to append new rows to the table, which is a bit hard to do with GtkGrid because it does not tell you the number of rows currently in the grid.
(In reply to comment #2) > The problem that I ran into was the way the providers actually add widgets to > the tables. They use these goa_util_* methods to append new rows to the table, > which is a bit hard to do with GtkGrid because it does not tell you the number > of rows currently in the grid. I learnt that with GtkGrid, one can just do gtk_container_add to append widgets, so this is not a problem at all. :-) If you haven't started working on this, then let me know. I plan to fix this next week (ie. after the Easter holidays).
Hi Debarshi, I haven't done any work on this so please do :)
Created attachment 212062 [details] [review] Replace GtkTable with GtkGrid
Reassigning to gnome-control-center since the panel needs to work with new API.
Created attachment 212063 [details] [review] online-accounts: goa_provider_show_account now expects GtkGrids, not GtkTable
*** Bug 674387 has been marked as a duplicate of this bug. ***
Review of attachment 212063 [details] [review]: Looks fine.
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
*** Bug 697443 has been marked as a duplicate of this bug. ***