GNOME Bugzilla – Bug 666792
Tables in net worth bar/line chart should show change/difference from previous entry
Last modified: 2018-06-29 23:04:09 UTC
Tables that show net worth over time should show the change/difference between entries. If I open up an Assets & Liabilities > Net Worth Bar Chart (or Line Chart, which is coming in the next version: https://bugzilla.gnome.org/show_bug.cgi?id=664862), I can make it show my change in Net Assets/worth over time. If I go into the Report Options and choose to have a table below the graph showing the values, it shows the Assets, Liabilities and Net Worth at each interval that is specified in the option. This gives a list like: Date Assets Liabilities Net Worth 23/02/08 100,000.00 -50,000.00 50,000.00 08/03/08 110,000.00 -50,000.00 60,000.00 22/03/08 110,000.00 -45,000.00 65,000.00 If I am producing a table showing the change in Net Worth over time, I would always be interested in the difference between each period. It would be great if this could be automatically generated, giving: Date Assets Liabilities Net Worth Difference 23/02/08 100,000.00 -50,000.00 50,000.00 N/A 08/03/08 110,000.00 -50,000.00 60,000.00 10,000.00 22/03/08 110,000.00 -45,000.00 65,000.00 5,000.00 This request flowed from my post to the mailing list here: http://lists.gnucash.org/pipermail/gnucash-user/2011-December/042252.html Thanks for all of your help!
Created attachment 281898 [details] Modified GnuCash Net Worth Line Chart Report. In case anybody is still interested, I have make some preliminary modifications to the standard Net Worth Line Chart report: 1. You can now specify "joint accounts" and what percentage (default is 50%) to count each joint account towards the total net worth. No joint accounts are selected by default, so the basic functionality of the unmodified report is not affected. 2. An additional "Change" column has been added to the table that contains the differences between net worth amounts for successive periods. See enhancement request 666792. 3. You can choose to arrange the table data in chronological order (Start Date first) or in reverse chronological order (End Date first). See enhancement request 666794. The new file name is "net-linechart-joint.scm". This modified report is still a work-in-progress, so use it at your own risk. Mike
Comment on attachment 281898 [details] Modified GnuCash Net Worth Line Chart Report. Line 34 should be: (define-module (gnucash report standard-reports net-linechart-joint)) Other than that is seems to work as described. Although I dibn't test the joint account feature.
(In reply to comment #2) > (From update of attachment 281898 [details]) > Line 34 should be: (define-module (gnucash report standard-reports > net-linechart-joint)) > > Other than that is seems to work as described. Although I dibn't test the > joint account feature. Thanks for the feedback regarding Line 34. I had not considered placing the file in the GnuCash "standard-reports" folder; instead, I used a personal config.user file to load the report. Anyway, if that change is made, would you then recommend changing Line 672 'menu-path (list gnc:menuname-utility) to 'menu-path (list gnc:menuname-asset-liability) so that the updated report appears in the same menu as the original net-linechart.scm? Thanks.
I don't see why there needs to be both reports since this is really an enhancement of the current report. In which case we probably should apply the same enhancement to the net worth bar chart too, since the line chart is derived from that.
Created attachment 282479 [details] Proposed replacement due to enhanced features (see comment). I've attached what I propose as a replacement for net-barchart.scm. Enhancements include: For the "Net Worth Barchart" report: 1. Table data can now be arranged in chronological or reverse chronological order. 2. Table data can now include changes and percent changes to Net Worth. 3. Joint accounts can be included that are weighted by a Joint Percent. For the "Income & Expense Chart" report: 1. Table data can now be arranged in chronological or reverse chronological order. 2. Table data can now include changes and percent changes to Net Profit.
Created attachment 282480 [details] Proposed replacement due to enhanced features (see comment). I've attached what I propose as a replacement for net-linechart.scm. Enhancements include: For the "Net Worth Linechart" report: 1. Table data can now be arranged in chronological or reverse chronological order. 2. Table data can now include changes and percent changes to Net Worth. 3. Joint accounts can be included that are weighted by a Joint Percent.
Created attachment 283148 [details] [review] Proposed replacement of net-linechart.scm. Updated with new features. The basic functionality of the report has not changed. New features include: * Joint accounts can be specified and weighted. * Display of the chart and table can be specified independently. * Tabular data can be arranged in chronological or reverse chronological order. * Changes and percent changes of Net Worth can be shown in the table. My primary interest in working on this report was to add the joint accounts feature.
Created attachment 283149 [details] [review] Proposed replacement of net-barchart.scm. Updated with new features. The basic functionality of the report has not changed. New features include: * Joint accounts can be specified and weighted. * Display of the chart and table can be specified independently. * Tabular data can be arranged in chronological or reverse chronological order. * Changes and percent changes of Net Worth/Net Profit can be shown in the table. My primary interest in working on this report was to add the joint accounts feature.
Thank you for posting reworked versions of both reports. That's a nice set of improvements you have added ! I'm having some issues from a source code management perspective. The two files you have added are the complete reports. From that it is pretty hard to see what actual changes you made. Normally we ask you to upload patches, which are only the differences between the original report and your report. There are several ways to generate such a diff file. For gnucash you best follow the guidelines in http://wiki.gnucash.org/wiki/Git Strictly speaking I could fairly easily create the basic diff file myself. That would still leave me with the changes to implement 4 different features per report. For me and anybody else not having written the changes, it would be very hard to figure out which changes were done for which new improvement. So generally we encourage people to split the set of changes in smaller subsets (called 'commits' in git) per improvement. That helps others understand and evaluate what you did and makes it easier to spot potential bugs in it than it would be in one big change set. Can you try to divide your big change set into several smaller ones ? Feel free to ask for more guidance if you're unsure how to do this. And then specifically to your new reports. From the diff file I generated from it I see that you have changed several option names. This is a problem for people that have saved reports based on the net-linechart.scm and net-barchart.scm. By changing the option names you are effectively creating new options (and deleting old ones), so the saved values of the old options will be lost. I believe this will upset several people. Can you revert the option names of existing options please ? Thanks.
GnuCash bug tracking has moved to a new Bugzilla host. The new URL for this bug is https://bugs.gnucash.org/show_bug.cgi?id=666792. Please continue processing the bug there and please update any external references or bookmarks.