After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 665121 - Stop using empathy_contact_list_get_all_groups
Stop using empathy_contact_list_get_all_groups
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
2.33.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2011-11-29 10:54 UTC by Guillaume Desmottes
Modified: 2011-11-29 13:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
add EmpathyConnectionAggregator (9.47 KB, patch)
2011-11-29 13:16 UTC, Guillaume Desmottes 		committed Details | Review
add empathy_connection_aggregator_get_all_groups() (2.09 KB, patch)
2011-11-29 13:16 UTC, Guillaume Desmottes 		committed Details | Review
groups-widget: use empathy_connection_aggregator_get_all_groups() (4.45 KB, patch)
2011-11-29 13:16 UTC, Guillaume Desmottes 		committed Details | Review
remove old school get_all_groups (5.40 KB, patch)
2011-11-29 13:17 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2011-11-29 10:54:06 UTC 
As part of bug #660547 we should stop using this function as use a modern equivalent instead.
Comment 1 Guillaume Desmottes 2011-11-29 13:16:53 UTC 
Created attachment 202370 [details] [review]
add EmpathyConnectionAggregator

It won't do much atm but will be used as a helper dealing with all
connections.
Comment 2 Guillaume Desmottes 2011-11-29 13:16:55 UTC 
Created attachment 202371 [details] [review]
add empathy_connection_aggregator_get_all_groups()
Comment 3 Guillaume Desmottes 2011-11-29 13:16:58 UTC 
Created attachment 202372 [details] [review]
groups-widget: use empathy_connection_aggregator_get_all_groups()

We have to prepare the contact groups feature and ensure that the singleton is
still alive. The 'empathy' process is the only one allowing user to change
contact groups so we just have to do it there.
Comment 4 Guillaume Desmottes 2011-11-29 13:17:01 UTC 
Created attachment 202373 [details] [review]
remove old school get_all_groups
Comment 5 Guillaume Desmottes 2011-11-29 13:28:30 UTC 
Attachment 202370 [details] pushed as 057fc31 - add EmpathyConnectionAggregator
Attachment 202371 [details] pushed as 97f3aec - add empathy_connection_aggregator_get_all_groups()
Attachment 202372 [details] pushed as 4532530 - groups-widget: use empathy_connection_aggregator_get_all_groups()
Attachment 202373 [details] pushed as 67869e5 - remove old school get_all_groups