GNOME Bugzilla – Bug 660547
Get rid of EmpathyContactManager
Last modified: 2011-12-14 12:30:22 UTC
EmpathyContactManager is still used in a lot of place in Empathy. We should audit the code and remove it as much as possible. Ideally we should use Folks directly. Furthermore, the contact manager uses EmpathyTpContactList which still use the old contact list API.
Created attachment 202434 [details] [review] connection-aggregator: add API to track contacts
Created attachment 202435 [details] [review] event-manager: use the conn aggregator instead of the contact mgr
Attachment 202434 [details] pushed as 0fe601d - connection-aggregator: add API to track contacts Attachment 202435 [details] pushed as 984c03d - event-manager: use the conn aggregator instead of the contact mgr
Created attachment 202607 [details] [review] contact-blocking-dialog: stop using EmpathyContactManager
Attachment 202607 [details] pushed as a9c67f1 - contact-blocking-dialog: stop using EmpathyContactManager
Bug shouldn't be closed yet.
Created attachment 203448 [details] [review] remove unused empathy_contact_edit_dialog_show()
Created attachment 203449 [details] [review] remove EMPATHY_CONTACT_WIDGET_EDIT_FAVOURITE It's not used any more and this code was the last one using the contact manager.
Created attachment 203450 [details] [review] main-window: stop instantiating the contact manager We don't use it any more.
Created attachment 203451 [details] [review] remove useless includes of empathy-contact-manager.h
Created attachment 203452 [details] [review] remove empathy-contact-manager
Attachment 203448 [details] pushed as c7524e2 - remove unused empathy_contact_edit_dialog_show() Attachment 203449 [details] pushed as 66dbf2d - remove EMPATHY_CONTACT_WIDGET_EDIT_FAVOURITE Attachment 203450 [details] pushed as 4228684 - main-window: stop instantiating the contact manager Attachment 203451 [details] pushed as 78120c0 - remove useless includes of empathy-contact-manager.h Attachment 203452 [details] pushed as 3c136f3 - remove empathy-contact-manager