After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 663626 - keyboard: Adjust shortcut files
keyboard: Adjust shortcut files
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Keyboard
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on: 663623
Blocks:
 
 
Reported: 2011-11-08 14:07 UTC by Florian Müllner
Modified: 2011-11-08 15:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
keyboard: Adjust shortcut files (2.27 KB, patch)
2011-11-08 14:07 UTC, Florian Müllner 		reviewed Details | Review
keyboard: Adjust shortcut files (1.78 KB, patch)
2011-11-08 14:25 UTC, Florian Müllner 		none Details | Review
keyboard: Adjust shortcut files (1.77 KB, patch)
2011-11-08 14:46 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2011-11-08 14:07:24 UTC 
See bug 663623.
Comment 1 Florian Müllner 2011-11-08 14:07:27 UTC 
Created attachment 200986 [details] [review]
keyboard: Adjust shortcut files

Some keybindings have been moved from metacity/mutter to g-s-d;
update the shortcut files to reflect that change.
Comment 2 Bastien Nocera 2011-11-08 14:09:49 UTC 
Review of attachment 200986 [details] [review]:

As mentioned in the gsd bug, I'd rather not have the terminal shortcut

::: panels/keyboard/01-screenshot.xml.in
@@ +1,2 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<KeyListEntries group="system" schema="org.gnome.settings-daemon.plugins.media-keys" _name="Screenshots">

"Screen Shots" as per https://live.gnome.org/Design/SystemSettings/Keyboard
Comment 3 Florian Müllner 2011-11-08 14:25:37 UTC 
Created attachment 200991 [details] [review]
keyboard: Adjust shortcut files

(In reply to comment #2)
> As mentioned in the gsd bug, I'd rather not have the terminal shortcut

OK.


> "Screen Shots" as per https://live.gnome.org/Design/SystemSettings/Keyboard

... and "Take a screen shot" then?
Comment 4 William Jon McCann 2011-11-08 14:44:45 UTC 
We adjusted after the mockups based on input from the docs team. I think Screeshots is preferred.
Comment 5 Florian Müllner 2011-11-08 14:46:14 UTC 
Created attachment 200995 [details] [review]
keyboard: Adjust shortcut files

Sure :)
Comment 6 Bastien Nocera 2011-11-08 14:55:46 UTC 
Review of attachment 200995 [details] [review]:

Good work on not using screeshots :)
Comment 7 Florian Müllner 2011-11-08 14:59:59 UTC 
Attachment 200995 [details] pushed as 7d060a2 - keyboard: Adjust shortcut files
Comment 8 Florian Müllner 2011-11-08 15:01:19 UTC 
(In reply to comment #6)
> Good work on not using screeshots :)

The assumption that the doc team would not actually recommend "screeshots" looked pretty safe :)