GNOME Bugzilla – Bug 663623
media-keys: Take over some shortcuts from metacity
Last modified: 2011-11-08 14:55:32 UTC
It's quite bizarre that "launch calculator" lives in g-s-d while "launch terminal" is handled by the window manager ...
Created attachment 200983 [details] [review] common: Allow to grab 'Print' without modifiers
Created attachment 200984 [details] [review] media-keys: Move some metacity shortcuts into g-s-d The shortcuts for launching a terminal and taking screenshots have been provided by the wm historically, but it makes more sense to handle them like other global shortcuts in the media-keys plugin.
Review of attachment 200983 [details] [review]: Looks correct (gnome-3-2 and master please)
Review of attachment 200984 [details] [review]: Rest looks fine. ::: data/org.gnome.settings-daemon.plugins.media-keys.gschema.xml.in.in @@ +106,3 @@ + <_description>Binding to take a screenshot of a window.</_description> + </key> + </key> We have the ability to launch arbitrary commands, do we really need a specific shortcut for launching a terminal? I'd say no.
Comment on attachment 200983 [details] [review] common: Allow to grab 'Print' without modifiers Attachment 200983 [details] pushed as 5c4d989 - common: Allow to grab 'Print' without modifiers
Created attachment 200989 [details] [review] media-keys: Move some metacity shortcuts into g-s-d (In reply to comment #4) > We have the ability to launch arbitrary commands, do we really need a specific > shortcut for launching a terminal? I'd say no. Yeah, makes sense.
Attachment 200989 [details] pushed as f32ae44 - media-keys: Move some metacity shortcuts into g-s-d Patch OK'ed on IRC, pushing.