GNOME Bugzilla – Bug 661998
background: Add context menu
Last modified: 2012-03-09 18:27:31 UTC
See patch. I'm unsure whether the background should be considered "system space", in which case a shell menu would probably be a better choice. If a "normal" GTK+ menu is what we want, the attached patch is lacking support for triggering the menu by keyboard shortcuts.
Created attachment 199210 [details] [review] background: Add context menu With desktop icons enabled, right clicks on the background trigger a context menu, which among other icon-view specific items contains a shortcut to the background settings panel. Add a similar context menu when gsd is drawing the desktop.
Review of attachment 199210 [details] [review]: Code looks correct. I'd be enclined to think that a shell menu would be more appropriate, but leaving that up to the designers.
*** Bug 647845 has been marked as a duplicate of this bug. ***
(In reply to comment #2) ... > I'd be enclined to think that a shell menu would be more > appropriate Agreed.
(In reply to comment #4) > (In reply to comment #2) > ... > > I'd be enclined to think that a shell menu would be more > > appropriate > > Agreed. Uhm - why did you close the shell bug then?
I'm not sure this is a good idea. I think that interaction with the OS should be done via the top bar or the message tray. Encouraging the use of the background doesn't seem like a good idea. I don't think we'd want to offer any other options here anyway besides change wallpaper anyway. I think it is better to have a way to set the wallpaper directly from an image in Photos or explicitly in the System Settings - so that we can set both the lock screen background and wallpaper to be the same if the user desires.
(In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #2) > > ... > > > I'd be enclined to think that a shell menu would be more > > > appropriate > > > > Agreed. > > Uhm - why did you close the shell bug then? Sorry, thought you wanted to track the bug from here... (In reply to comment #6) > I'm not sure this is a good idea. I think that interaction with the OS should > be done via the top bar or the message tray. Encouraging the use of the > background doesn't seem like a good idea. I don't think we'd want to offer any > other options here anyway besides change wallpaper anyway. I think it is better > to have a way to set the wallpaper directly from an image in Photos or > explicitly in the System Settings - so that we can set both the lock screen > background and wallpaper to be the same if the user desires. I think it is logical to enable someone to change the background by directly clicking on it. Also, changing the background using a context menu is a convention that a lot of people are familiar with. The menu could contain a single item ('Change Wallpaper...') that would open the appropriate systems settings panel.
I'll reiterate that I think this isn't a good idea. I don't think having a single item in a menu is a good reason to have the menu. I don't think we want to have the equivalent option on the lock screen or in the overview and generally speaking we don't expect people to be looking at empty backgrounds. Add new pathways like this comes at a cost.
Agreed with Jon, closing.