GNOME Bugzilla – Bug 661981
new message/call dialog: use EmpathyContactChooser
Last modified: 2011-10-20 22:37:54 UTC
It would provide a better and more coherent UI.
Created attachment 199193 [details] [review] new-call-dialog: fix typo in comment
Created attachment 199194 [details] [review] factor out empathy_individual_can_audio_video_call() Also allow caller to get a ref on the EmpathyContact supporting audio/video.
Created attachment 199195 [details] [review] new-call-dialog: port to EmpathyContactChooser Replace the 'send video' checkbox by an extra button It's more coherent with the other places where we allow user to start calls. It also gives better feedback as we can unsensitive this button if the selected contact doesn't support video.
This is just the new call dialog. I'll do the text one now
Review of attachment 199193 [details] [review]: ++
Review of attachment 199194 [details] [review]: ::: libempathy/empathy-utils.c @@ +1132,3 @@ + + g_object_unref (contact); + Empty space after braces. @@ +1138,3 @@ + if (can_audio && can_video) + break; + Here too. @@ +1145,3 @@ + + if (can_video_call != NULL) + { Suspect indenting.
Review of attachment 199195 [details] [review]: ++
(In reply to comment #6) > Review of attachment 199194 [details] [review]: > > ::: libempathy/empathy-utils.c > @@ +1132,3 @@ > + > + g_object_unref (contact); > + > > Empty space after braces. fixed. > @@ +1138,3 @@ > + if (can_audio && can_video) > + break; > + > > Here too. fixed. > @@ +1145,3 @@ > + > + if (can_video_call != NULL) > + { > > Suspect indenting. fixed.
Attachment 199193 [details] pushed as 5af3f21 - new-call-dialog: fix typo in comment Attachment 199194 [details] pushed as 588247c - factor out empathy_individual_can_audio_video_call() Attachment 199195 [details] pushed as 625867b - new-call-dialog: port to EmpathyContactChooser
Created attachment 199314 [details] [review] new-message-dialog: port to EmpathyContactChooser
Created attachment 199315 [details] [review] new-call-dialog: use the self->priv pattern
Review of attachment 199314 [details] [review]: ::: libempathy-gtk/empathy-new-message-dialog.c @@ +168,3 @@ + contact = empathy_contact_dup_best_for_action (individual, + EMPATHY_ACTION_CHAT); + g_return_if_fail (contact != NULL); Leaks @individual. @@ +180,3 @@ + contact = empathy_contact_dup_best_for_action (individual, + EMPATHY_ACTION_SMS); + g_return_if_fail (contact != NULL); Here too.
Review of attachment 199315 [details] [review]: ++
Review of attachment 199314 [details] [review]: ::: libempathy-gtk/empathy-new-message-dialog.c @@ +168,3 @@ + contact = empathy_contact_dup_best_for_action (individual, + EMPATHY_ACTION_CHAT); + g_return_if_fail (contact != NULL); How so? See the code after out: tp_clear_object (&individual); tp_clear_object (&contact);
Attachment 199314 [details] pushed as 7e68d58 - new-message-dialog: port to EmpathyContactChooser Attachment 199315 [details] pushed as d895fd8 - new-call-dialog: use the self->priv pattern
Created attachment 199489 [details] [review] fixes http://cgit.collabora.com/git/user/danni/empathy.git/log/?h=dialog-cleanup This patch removes the extra buttons (caused by a missing parameter) and swaps the button ordering. It also removes the old contact-selector-dialog. [Random thought: I wonder how much other unused code there is in Empathy... worth checking maybe.]
(In reply to comment #16) > [Random thought: I wonder how much other unused code there is in Empathy... > worth checking maybe.] It seems that every class is used somewhere. Well done us.
++