GNOME Bugzilla – Bug 661728
dialpad for new conversation/new call
Last modified: 2018-05-22 15:09:15 UTC
Created attachment 198988 [details] [review] patch This is a forward port from an Empathy 2.34 branch that I've tweaked and updated. Someone wanted a dialpad on New Call, so that they could dial numbers like 1800-GET-ROB into Empathy. http://cgit.collabora.com/git/user/danni/empathy.git/log/?h=dialpad-port This branch ports the original patch, then removes the confusing toggle button, adds a backspace button and does some general tweaking.
http://cgit.collabora.com/git/user/danni/empathy.git/commit/?h=dialpad-port&id=de736eae719ddf916fa7b61bfb0dc8bef9bbe8c3 I don't agree. I think it should be hidden by default (at least for 'new message'). Especially now that we have a nice icon to hide/display it. Furthermore, we'll probably have to make it optionnal when we'll switch to the new contact selector (as in the invite participant dialog). http://cgit.collabora.com/git/user/danni/empathy.git/commit/?h=dialpad-port&id=aeeba5fa781e8cf14ba5435a759508f879dd1453 What's the point of it? Why not have a 'clear' icon in the entry itself as in other GNOME entries?
(In reply to comment #1) > I don't agree. I think it should be hidden by default (at least for 'new > message'). Especially now that we have a nice icon to hide/display it. Ok. I'll back that change out. Not having an icon was part of my issue to be honest. > What's the point of it? Why not have a 'clear' icon in the entry itself as in > other GNOME entries? I think it should be 'backspace' rather than clear. I'm happy to move it inside the entry. Quoting RGS: """ As is the case with the n900 where you have a button in the dial pad to delete the numbers you've already punched in, I think we should have the same in Empathy. It's kind of awkward to insert some numbers be clicking and then having to resort to the keyboard to fix what was wrong. """
(In reply to comment #2) > > What's the point of it? Why not have a 'clear' icon in the entry itself as in > > other GNOME entries? > > I think it should be 'backspace' rather than clear. I'm happy to move it inside > the entry. Quoting RGS: > > """ > As is the case with the n900 where you have a button in the dial pad to delete > the numbers you've already punched in, I think we should have the same in > Empathy. It's kind of awkward to insert some numbers be clicking and then > having to resort to the keyboard to fix what was wrong. > """ Ok maybe.
Created attachment 199397 [details] [review] refactor dialpad into a proper widget Following on from the new new-convo/call dialogs that were merged the other day, I've decided to totally redo this. First up, something that wasn't done in the original patch I forward ported (not my work), was to refactor the dialpad into its own widget. I think this is an important first step for enabling reuse of the dialpad in other places in Empathy. This patch creates a new widget, EmpathyDialpadWidget, which has two signals users can connect to, ::start-tone and ::stop-tone. empathy-av and empathy-call have been ported to this widget. I think it cleans up use of the dialpad significantly. http://cgit.collabora.com/git/user/danni/empathy.git/log/?h=dialpad-widget
Those 2 patches looks good. The new file doesn't seem to contain any translatable string but best to run "make check" to make sure it shouldn't be added to POTFILES.in.
Comment on attachment 199397 [details] [review] refactor dialpad into a proper widget make check passes fine. Committed.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/empathy/issues/448.