GNOME Bugzilla – Bug 661489
Should just use Folks to get favorites
Last modified: 2011-10-14 20:50:17 UTC
Some part of the code use Folks to get favorites and some still use the logger directly. We should just rely on Folks.
Created attachment 199027 [details] [review] remove unused EMPATHY_CONTACT_FEATURE_FAVOURITE
Created attachment 199028 [details] [review] contact-list-store: remove 'fake group' code This store is only used for MUC members which doesn't use these fake groups. Actually we could drop all the group code but it would probably be easier to completely rewrite the way we display MUC members.
Created attachment 199029 [details] [review] contact-manager: remove unused favourite code
Created attachment 199030 [details] [review] contact-manager: remove unused favourite code
Review of attachment 199027 [details] [review]: Looks good to me.
Review of attachment 199028 [details] [review]: ::: libempathy-gtk/empathy-contact-list-store.c @@ -1522,2 @@ NULL }; Couldn't all the code which touches top_groups and bottom_groups now be removed, since they're always empty? ::: libempathy-gtk/empathy-contact-list-store.h @@ -72,3 @@ -#define EMPATHY_CONTACT_LIST_STORE_FAVORITE _("Favorite People") -#define EMPATHY_CONTACT_LIST_STORE_PEOPLE_NEARBY _("People Nearby") - I think this file can now be removed from POTFILES.in, since all its translatable strings are dead and buried.
Review of attachment 199030 [details] [review]: ::: libempathy/empathy-contact-manager.c @@ -921,3 @@ - iface->is_favourite = contact_manager_is_favourite; - iface->remove_favourite = contact_manager_remove_favourite; - iface->add_favourite = contact_manager_add_favourite; I wonder if these three methods should be removed from the ContactList interface too.
(In reply to comment #6) > Review of attachment 199028 [details] [review]: > > ::: libempathy-gtk/empathy-contact-list-store.c > @@ -1522,2 @@ > NULL > }; > > Couldn't all the code which touches top_groups and bottom_groups now be > removed, since they're always empty? removed. > ::: libempathy-gtk/empathy-contact-list-store.h > @@ -72,3 @@ > -#define EMPATHY_CONTACT_LIST_STORE_FAVORITE _("Favorite People") > -#define EMPATHY_CONTACT_LIST_STORE_PEOPLE_NEARBY _("People Nearby") > - > > I think this file can now be removed from POTFILES.in, since all its > translatable strings are dead and buried. Good point; removed. (In reply to comment #7) > Review of attachment 199030 [details] [review]: > > ::: libempathy/empathy-contact-manager.c > @@ -921,3 @@ > - iface->is_favourite = contact_manager_is_favourite; > - iface->remove_favourite = contact_manager_remove_favourite; > - iface->add_favourite = contact_manager_add_favourite; > > I wonder if these three methods should be removed from the ContactList > interface too. Good idea; I'll remove them.
Created attachment 199032 [details] [review] contact-list-store: remove 'fake group' code This store is only used for MUC members which doesn't use these fake groups. Actually we could drop all the group code but it would probably be easier to completely rewrite the way we display MUC members.
Created attachment 199034 [details] [review] contact-list-store: stop tracking favourite contacts
Created attachment 199035 [details] [review] contact-list: remove favourite API
Review of attachment 199032 [details] [review]: Looks good to me.
Review of attachment 199035 [details] [review]: Looks good to me.
Review of attachment 199034 [details] [review]: Ship it!
Attachment 199027 [details] pushed as 3e2f155 - remove unused EMPATHY_CONTACT_FEATURE_FAVOURITE Attachment 199030 [details] pushed as 21999bc - contact-manager: remove unused favourite code Attachment 199032 [details] pushed as 9357aef - contact-list-store: remove 'fake group' code Attachment 199034 [details] pushed as 960bbbe - contact-list-store: stop tracking favourite contacts Attachment 199035 [details] pushed as d6763a0 - contact-list: remove favourite API