After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 661482 - Browse result is not consistent in All* containers
Browse result is not consistent in All* containers
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: general
git master
Other Linux
: Normal major
: ---
Assigned To: rygel-maint
rygel-maint
: 674630 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-10-11 18:31 UTC by Jens Georg
Modified: 2012-08-12 17:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch proposal (30.81 KB, patch)
2012-03-01 08:14 UTC, Lukasz Pawlik 		none Details | Review
patch is fixing tests (4.78 KB, patch)
2012-03-01 08:14 UTC, Lukasz Pawlik 		committed Details | Review
core,tracker: Sort before slicing (32.11 KB, patch)
2012-08-05 16:54 UTC, Jens Georg 		committed Details | Review

Description Jens Georg 2011-10-11 18:31:23 UTC 
e.g.:

Browse AllMusic with:

Browse ("AllMusic", "BrowseDirectChildren", "dc:title", 0, 0, "+dc:title")

Let the result be:

Item_1,
Item_2,
Item_3,
Item_4,
Item_5,
Item_6

And then:

Browse ("AllMusic", "BrowseDirectChildren", "dc:title", 4, 2, "+dc:title")

The result is something like:

Item_2,
Item_5

And not Item_5 & Item_6 as expected.
Comment 1 Jens Georg 2012-01-28 14:27:30 UTC 
Probably a "sorting after slicing" issue
Comment 2 Lukasz Pawlik 2012-02-27 10:58:54 UTC 
With Tracker 0.12.9 Browse results are returned properly.
Comment 3 Jens Georg 2012-02-27 11:22:26 UTC 
Moving to tracker and resolving.
Comment 4 Jens Georg 2012-02-27 12:08:15 UTC 
Whoops. Not fixed and our bug. Only worked by accident on 0.12.9
Comment 5 Jens Georg 2012-02-29 20:05:30 UTC 
Oh wow, that breaks sliced browsing on that container completely :(
Comment 6 Lukasz Pawlik 2012-03-01 08:14:00 UTC 
Created attachment 208770 [details] [review]
patch proposal

Also Search results when StrrtingIndex is in used are not consistent. Patch works only with tracker plugin and somehow cover bug 668376.
Comment 7 Lukasz Pawlik 2012-03-01 08:14:40 UTC 
Created attachment 208771 [details] [review]
patch is fixing  tests
Comment 8 Jens Georg 2012-03-01 13:55:33 UTC 
ake[4]: Entering directory `/home/jens/Source/rygel/src/plugins/media-export'
  VALAC  librygel_media_export_la_vala.stamp
rygel-media-export-leaf-query-container.vala:29.5-29.52: error: overriding method `Rygel.MediaExport.LeafQueryContainer.get_children' is incompatible with base method `Rygel.MediaContainer.get_children': incompatible type of parameter 3.
    public override async MediaObjects? get_children (uint         offset,
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
rygel-media-export-leaf-query-container.vala:29.5-29.52: error: Rygel.MediaExport.LeafQueryContainer.get_children: no suitable method found to override
    public override async MediaObjects? get_children (uint         offset,
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
rygel-media-export-node-query-container.vala:46.5-46.52: error: overriding method `Rygel.MediaExport.NodeQueryContainer.get_children' is incompatible with base method `Rygel.MediaContainer.get_children': incompatible type of parameter 3.
    public override async MediaObjects? get_children (uint         offset,
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
rygel-media-export-node-query-container.vala:46.5-46.52: error: Rygel.MediaExport.NodeQueryContainer.get_children: no suitable method found to override
    public override async MediaObjects? get_children (uint         offset,
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
rygel-media-export-root-container.vala:170.56-170.66: error: Argument 3: Cannot convert from `GLib.Cancellable?' to `string'
                                                       cancellable);
                                                       ^^^^^^^^^^^
Comment 9 Jens Georg 2012-03-01 14:02:24 UTC 
The tracker part seems to work well, thank you for the patch
Comment 10 Jens Georg 2012-03-02 13:12:51 UTC 
Apart from the root container. If a device requests the items one by one, it's still wrong.
Comment 11 Jens Georg 2012-04-26 17:54:22 UTC 
Basically applies to everything, even MediaExport.
Comment 12 Jens Georg 2012-04-26 17:55:30 UTC 
*** Bug 674630 has been marked as a duplicate of this bug. ***
Comment 13 Jens Georg 2012-08-05 16:54:36 UTC 
Created attachment 220373 [details] [review]
core,tracker: Sort before slicing

Rebase against latest tracker refactoring
Comment 14 Jens Georg 2012-08-12 17:53:55 UTC 
Attachment 220373 [details] pushed as 7abecff - core,tracker: Sort before slicing