After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 659644 - Added rules to build winks with the mingw-w64 toolchain
Added rules to build winks with the mingw-w64 toolchain
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Windows
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 672136 (view as bug list)
Depends on: 702041
Blocks:
 
 
Reported: 2011-09-20 21:08 UTC by Andres Colubri
Modified: 2014-05-22 15:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
winks rules (3.50 KB, application/octet-stream)
2011-09-20 21:08 UTC, Andres Colubri 		  Details
Winks patch generated with git format-patch (3.93 KB, patch)
2011-09-25 13:23 UTC, Andres Colubri 		needs-work Details | Review

Description Andres Colubri 2011-09-20 21:08:58 UTC 
Created attachment 197112 [details]
winks rules

Some missing definitions were recently incorporated to the CRT of mingw-w64:

http://sourceforge.net/tracker/?func=detail&atid=983357&aid=3408117&group_id=202880

which makes possible to compile the winks plugin with the mingw-w64 cross compiler.

Until now, the rules in the am and ac files in the gst-plugins-bad package ignored this plugin.

I'm submitting a patch that adds these rules. I generated this patch against the latest code I checked out from git.
Comment 1 David Schleef 2011-09-24 21:16:08 UTC 
Could you reattach the patch as a git commit, created using 'git format-patch'?  This makes it easier to review and merge.  Thanks.
Comment 2 Andres Colubri 2011-09-25 13:23:04 UTC 
Created attachment 197425 [details] [review]
Winks patch generated with git format-patch
Comment 3 Andres Colubri 2011-09-25 13:41:37 UTC 
BTW, it seems that these patches 

https://bugzilla.gnome.org/show_bug.cgi?id=599394
https://bugzilla.gnome.org/show_bug.cgi?id=577050

haven't been included to the trunk, right?
Comment 4 Levente Farkas 2011-10-13 13:54:17 UTC 
is there any change that these changes get into the git before the next release?
Comment 5 Sebastian Dröge (slomo) 2012-07-03 10:26:59 UTC 
*** Bug 672136 has been marked as a duplicate of this bug. ***
Comment 6 Sebastian Dröge (slomo) 2014-01-25 14:02:37 UTC 
This depends on bug #702041 now, everything has to be ported to 1.0 first.
Comment 7 Edward Hervey 2014-05-19 13:55:04 UTC 
winks is now ported. Is this patch still needed ?
Comment 8 Edward Hervey 2014-05-22 15:07:17 UTC 
works fine with mingw32/64 whether cross-compiling or on windows itself. Closing.