After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658522 - Bad tabbing order for Change Password in user accounts panel
Bad tabbing order for Change Password in user accounts panel
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: User Accounts
3.1.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-09-08 03:06 UTC by Dylan McCall
Modified: 2012-05-23 14:46 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Dylan McCall 2011-09-08 03:06:22 UTC
The user accounts panel has a password changing dialog. Pressing Tab from the New password field, after typing in that field, brings focus to a button for generating a random password. Users will expect the Confirm password field to be focused instead because it is naturally the next step after typing in the first password field.

Adding to this issue, the dropdown is not particularly understandable when accessed through the keyboard; the only thing that really says what it does is a tooltip. A user could easily choose one of the options out of confusion, changing the new password he just entered.
Comment 1 Dylan McCall 2011-09-08 03:08:32 UTC
Oops, two other notes.

First, that other issue I mentioned is bug #633601, for reference. (https://bugzilla.gnome.org/show_bug.cgi?id=633601).

Also, this was originally filed downstream at https://bugs.launchpad.net/gnome-control-center/+bug/821761.
Comment 2 Bastien Nocera 2011-09-09 08:59:34 UTC
commit 1ed6f51d8ef4081c7c463661357f4d5c8a9b10b3
Author: Bastien Nocera <hadess@hadess.net>
Date:   Fri Sep 9 09:57:35 2011 +0100

    user-accounts: Correct initial focus in password dialogue
    
    The password dialogue needs to have the "Current password" field
    focused by default if we're changing the password.
Comment 3 Bastien Nocera 2011-09-09 09:00:40 UTC
Wrong bug.

What do you think the ordering of the tab focus should be then? Where does the button fit in in the loop?
Comment 4 Dylan McCall 2011-10-12 19:15:38 UTC
The button probably fits best before the first New password field, since that way it affects the field immediately after it in the tab order. Probably worth bringing up with the usability folks; I could easily be imagining this problem, and really I shouldn't have put it in the same bug report :)

Thanks for the fix!
Comment 5 Sebastien Bacher 2012-01-27 15:36:10 UTC
Right, I ran into that today, it seems to make little sense to have it between the password and confirmation because that matches no standard workflow (i.e you use the generator or type password but there is no case where you need the generator after having typed a manual password)

- if it was before it would probably mean it's the recommended option (i.e that would get suggested before typing one manually)
- if it's after it means that people who want to reach hit would need to skip the 2 password fields, which is easy enough
Comment 6 William Jon McCann 2012-05-04 20:06:15 UTC
I've hit this too. I agree that the confirm should follow the initial in the tab order.
Comment 7 Matthias Clasen 2012-05-23 14:46:15 UTC
The button has been turned into an icon in the entry, so no longer a separate focus location. Problem solved.

The generate password functionality is still keyboard accessible via the context menu.