After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 633601 - Gears icon not clear that it contains generated passwords
Gears icon not clear that it contains generated passwords
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: User Accounts
git master
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-10-31 00:30 UTC by William Jon McCann
Modified: 2012-05-23 21:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
a patch (11.42 KB, patch)
2012-05-09 02:00 UTC, Matthias Clasen
none Details | Review
how it looks (27.31 KB, image/png)
2012-05-09 02:00 UTC, Matthias Clasen
  Details
with tooltip (30.06 KB, image/png)
2012-05-09 02:01 UTC, Matthias Clasen
  Details
user-accounts: Simplify generated password handling (12.21 KB, patch)
2012-05-19 06:17 UTC, Matthias Clasen
none Details | Review
users: Make generated password visible (1.07 KB, patch)
2012-05-19 21:10 UTC, Matthias Clasen
none Details | Review
users: Make generated password visible (1.07 KB, patch)
2012-05-23 12:31 UTC, Matthias Clasen
committed Details | Review
user-accounts: Simplify generated password handling (12.21 KB, patch)
2012-05-23 12:32 UTC, Matthias Clasen
committed Details | Review

Description William Jon McCann 2010-10-31 00:30:26 UTC
I'm not sure the gears icon is clear that it contains generated passwords.  We can try to think of something better.
Comment 1 Acorn Pooley 2011-03-21 23:55:26 UTC
*** Bug 636811 has been marked as a duplicate of this bug. ***
Comment 2 Matthias Clasen 2011-09-01 22:08:30 UTC
We need a better icon, then. Artist help needed
Comment 3 William Jon McCann 2012-05-04 21:02:50 UTC
Jakub, have any ideas?
Comment 4 Jakub Steiner 2012-05-06 12:06:35 UTC
Well I don't think the metaphor itself is what's not working. It's the fact that the button is separated from the password entry. If the icon was symbolic* and part of the entry in a similar way the reload button is in Web's URL entry, it might be more obvious.

* system-run-symbolic

Nevertheless an asteriskcombined with an arrow pointing to the right might work better for password-generate too.
Comment 5 Matthias Clasen 2012-05-09 02:00:37 UTC
Created attachment 213717 [details] [review]
a patch

How about this ?

Move the 'generate password' icon into the entry to make
the focus chain more straightforward. Also switch from
generating a choice of 6 passwords in a menu, just generate
a single one and put it directly into the entry.
To keep the password generation keyboard accessible,
add a 'Generate password' context menu item.
Comment 6 Matthias Clasen 2012-05-09 02:00:57 UTC
Created attachment 213718 [details]
how it looks
Comment 7 Matthias Clasen 2012-05-09 02:01:21 UTC
Created attachment 213719 [details]
with tooltip
Comment 8 William Jon McCann 2012-05-09 02:38:14 UTC
In general I really like this. There is a pretty annoying lag sometimes though. And I think we need to show the password in the clear if we use this. I need to read it to be able to repeat it.
Comment 9 Matthias Clasen 2012-05-09 04:05:13 UTC
I believe the lag happens when /dev/random has no entropy.

Try cat /dev/random, and then run apg -n1 in another terminal

Few ideas: 

- run apg async, instead of blocking the ui

- generate a dozen passwords in advance, and serve them out one-by-one
Comment 10 Matthias Clasen 2012-05-19 06:17:45 UTC
Created attachment 214435 [details] [review]
user-accounts: Simplify generated password handling

Move the 'generate password' icon into the entry to make
the focus chain more straightforward. Also switch from
generating a choice of 6 passwords in a menu, just put
put the next choice directly into the entry.
To keep the password generation keyboard accessible,
add a 'Generate password' context menu item.

https://bugzilla.gnome.org/show_bug.cgi?id=633601
https://bugzilla.gnome.org/show_bug.cgi?id=658522
Comment 11 Matthias Clasen 2012-05-19 06:18:54 UTC
same ui, but now we generate 10 passwords at a time, to avoid running agp every time.
Comment 12 Matthias Clasen 2012-05-19 21:10:38 UTC
Created attachment 214461 [details] [review]
users: Make generated password visible

A generated password is useless if you can't read it.
Comment 13 Matthias Clasen 2012-05-23 12:31:55 UTC
The following fixes have been pushed:
86bd905 users: Make generated password visible
a7beb08 user-accounts: Simplify generated password handling
Comment 14 Matthias Clasen 2012-05-23 12:31:59 UTC
Created attachment 214751 [details] [review]
users: Make generated password visible

A generated password is useless if you can't read it.
Comment 15 Matthias Clasen 2012-05-23 12:32:02 UTC
Created attachment 214752 [details] [review]
user-accounts: Simplify generated password handling

Move the 'generate password' icon into the entry to make
the focus chain more straightforward. Also switch from
generating a choice of 6 passwords in a menu, just put
put the next choice directly into the entry.
To keep the password generation keyboard accessible,
add a 'Generate password' context menu item.

https://bugzilla.gnome.org/show_bug.cgi?id=633601
https://bugzilla.gnome.org/show_bug.cgi?id=658522