After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658332 - Deprecate PersonaStore.can-[alias|group]-personas
Deprecate PersonaStore.can-[alias|group]-personas
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: libfolks
git master
Other All
: Normal minor
: Future
Assigned To: folks-maint
folks-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-06 07:27 UTC by Philip Withnall
Modified: 2011-09-20 13:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.62 KB, patch)
2011-09-19 11:39 UTC, Raul Gutierrez Segales 		accepted-commit_now Details | Review

Description Philip Withnall 2011-09-06 07:27:06 UTC 
From my e-mail of 2011-09-03:

 • PersonaStore.can-alias-personas and PersonaStore.can-group-personas
   should be deprecated in favour of
   PersonaStore.always-writeable-properties and
   Persona.writeable-properties. I don't think losing the
   MaybeBool.UNSET state (i.e. going from a tri-state to a boolean)
   should cause any problems, since in practice MaybeBool.UNSET was
   treated identically to MaybeBool.FALSE.

The only place I can find them being used is in Empathy, which just checks for can-[alias|group]-personas == MaybeBool.TRUE; effectively treating .FALSE and .UNSET as identical.

I guess there might be other software which cares more, though. What about QtFolks? If it does, this bug might have to be reconsidered.

Regardless, the API is doing little harm at the moment, so there's no pressure to get it removed for GNOME 3.2.
Comment 1 Raul Gutierrez Segales 2011-09-19 11:39:11 UTC 
Created attachment 196926 [details] [review]
patch

Following up with a ticket (and patch) against Empathy to use always-writeable-properties.
Comment 2 Raul Gutierrez Segales 2011-09-19 14:17:10 UTC 
Bug report for Empathy: https://bugzilla.gnome.org/show_bug.cgi?id=659476
Comment 3 Travis Reitter 2011-09-19 18:09:13 UTC 
Review of attachment 196926 [details] [review]:

Looks good to me.
Comment 4 Philip Withnall 2011-09-19 18:30:47 UTC 
Review of attachment 196926 [details] [review]:

Looks good to me, with these minor changes.

::: NEWS
@@ +6,3 @@
+API changes:
+* Deprecate Folks.PersonaStore.can_alias_personas
+* Deprecate Folks.PersonaStore.can_group_personas

Would be useful to give a hint that people should use Persona.writeable-properties instead and PersonaStore.always-writeable-properties instead.

::: folks/persona-store.vala
@@ +450,3 @@
    * @since 0.3.1
    */
+  [Deprecated (since = "0.6.4",

s/0.6.4/UNRELEASED/

@@ +463,3 @@
    * @since 0.3.1
    */
+  [Deprecated (since = "0.6.4",

s/0.6.4/UNRELEASED/
Comment 5 Raul Gutierrez Segales 2011-09-20 13:14:03 UTC 
Merged:

commit 67f55ab19dc994559f224c3d006aed81789cde04
Author: Raul Gutierrez Segales <rgs@collabora.co.uk>
Date:   Mon Sep 19 12:38:08 2011 +0100

    Deprecate PersonaStore.can-[alias|group]-personas
    
    Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=658332