After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 659476 - Remove Folks deprecated API
Remove Folks deprecated API
Product: empathy
Classification: Core
Component: General
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on:
Reported: 2011-09-19 14:14 UTC by Raul Gutierrez Segales
Modified: 2011-09-19 14:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

patch (6.13 KB, patch)
2011-09-19 14:14 UTC, Raul Gutierrez Segales
reviewed Details | Review

Description Raul Gutierrez Segales 2011-09-19 14:14:14 UTC
Created attachment 196946 [details] [review]

The folks_persona_store_get_can_{alias, groups}_personas methods are on the road to being deprecated in favour of directly checking for if 'alias' and 'groups' properties are writeable via folks_persona_store_get_always_writeable_properties and folks_persona_get_writeable_properties. 

Attaching a patch to move to the new way.
Comment 1 Guillaume Desmottes 2011-09-19 14:19:09 UTC
Review of attachment 196946 [details] [review]:

::: libempathy/empathy-utils.c
@@ +82,3 @@
+static gboolean
+properties_contains (gchar **list, gint length, const gchar *property);

one arg per line please.

@@ +1028,3 @@
+static gboolean
+properties_contains (gchar **list, gint length, const gchar *property)

One arg per line.

@@ +1034,3 @@
+  for (i = 0; i < length; i++)
+    {
+      if (strcmp (list[i], property) == 0)

Use tp_strdiff()
Comment 2 Raul Gutierrez Segales 2011-09-19 14:28:05 UTC

commit aaff7e95f9dd66f94a3b85e910b049daf9097a0c
Author: Raul Gutierrez Segales <>
Date:   Mon Sep 19 15:09:57 2011 +0100

    Use always-writeable and writeable-properties for alias and groups
    Folks is in the way of deprecating the
    folks_persona_store_get_can_{alias,group}_personas methods in favour
    of directly checking alias and groups properties via
    folks_persona_store_get_always_writeable_properties and