After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658245 - Use TpFileTransferChannel
Use TpFileTransferChannel
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: File Transfer
3.1.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on:
Blocks: 640513
 
 
Reported: 2011-09-05 11:58 UTC by Emilio Pozuelo Monfort
Modified: 2011-09-27 13:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
pass to proper user action time when requesting an outgoing FT (6.59 KB, patch)
2011-09-27 12:36 UTC, Guillaume Desmottes 		none Details | Review
tp-file: chain up constructed (784 bytes, patch)
2011-09-27 12:37 UTC, Guillaume Desmottes 		committed Details | Review
EmpathyTpFile: inherit from TpFileTransferChannel (13.56 KB, patch)
2011-09-27 12:37 UTC, Guillaume Desmottes 		committed Details | Review
remove empathy_tp_file_is_incoming() (3.32 KB, patch)
2011-09-27 12:37 UTC, Guillaume Desmottes 		committed Details | Review
don't connect on the TransferredBytesChanged D-Bus signal (2.06 KB, patch)
2011-09-27 12:37 UTC, Guillaume Desmottes 		committed Details | Review
ft-handler: Use TpFileTransferChannel properties (2.73 KB, patch)
2011-09-27 12:37 UTC, Guillaume Desmottes 		committed Details | Review
pass to proper user action time when requesting an outgoing FT (6.35 KB, patch)
2011-09-27 12:47 UTC, Guillaume Desmottes 		committed Details | Review

Description Emilio Pozuelo Monfort 2011-09-05 11:58:31 UTC 
We should use the new high level TpFileTransferChannel in Empathy to simplify the code
Comment 1 Guillaume Desmottes 2011-09-27 12:36:55 UTC 
Created attachment 197560 [details] [review]
pass to proper user action time when requesting an outgoing FT
Comment 2 Guillaume Desmottes 2011-09-27 12:37:26 UTC 
Created attachment 197561 [details] [review]
tp-file: chain up constructed
Comment 3 Guillaume Desmottes 2011-09-27 12:37:34 UTC 
Created attachment 197562 [details] [review]
EmpathyTpFile: inherit from TpFileTransferChannel
Comment 4 Guillaume Desmottes 2011-09-27 12:37:42 UTC 
Created attachment 197563 [details] [review]
remove empathy_tp_file_is_incoming()
Comment 5 Guillaume Desmottes 2011-09-27 12:37:49 UTC 
Created attachment 197564 [details] [review]
don't connect on the TransferredBytesChanged D-Bus signal
Comment 6 Guillaume Desmottes 2011-09-27 12:37:57 UTC 
Created attachment 197565 [details] [review]
ft-handler: Use TpFileTransferChannel properties
Comment 7 Guillaume Desmottes 2011-09-27 12:47:07 UTC 
Created attachment 197566 [details] [review]
pass to proper user action time when requesting an outgoing FT
Comment 8 Xavier Claessens 2011-09-27 12:58:57 UTC 
looks good now.
Comment 9 Guillaume Desmottes 2011-09-27 13:12:33 UTC 
Merged to master.

Attachment 197561 [details] pushed as 88fc949 - tp-file: chain up constructed
Attachment 197562 [details] pushed as a3d1d0d - EmpathyTpFile: inherit from TpFileTransferChannel
Attachment 197563 [details] pushed as ef81d18 - remove empathy_tp_file_is_incoming()
Attachment 197564 [details] pushed as d3531f4 - don't connect on the TransferredBytesChanged D-Bus signal
Attachment 197565 [details] pushed as caad2d2 - ft-handler: Use TpFileTransferChannel properties
Attachment 197566 [details] pushed as a93e738 - pass to proper user action time when requesting an outgoing FT