After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658144 - Backlight sometimes DIM to a higher level
Backlight sometimes DIM to a higher level
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: power
3.1.x
Other Linux
: Normal normal
: ---
Assigned To: Richard Hughes
gnome-settings-daemon-maint
: 657850 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-09-03 22:03 UTC by jean-louis
Modified: 2011-09-07 13:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Only dim if old brightness was higher than dim brightness. And also fix typo :) (1.71 KB, patch)
2011-09-03 22:14 UTC, jean-louis 		none Details | Review
test patch (4.48 KB, patch)
2011-09-04 20:31 UTC, Richard Hughes 		none Details | Review

Description jean-louis 2011-09-03 22:03:50 UTC 
When I have my backlight set to a low level, the DIM function changes the backlight to a higher level than the current one.

This is something we don't want, and should be fixed :)


This is quite easy to fix with the following patch:
https://launchpadlibrarian.net/78879888/gnome-settings-daemon.debdiff
Comment 1 jean-louis 2011-09-03 22:14:27 UTC 
Created attachment 195602 [details] [review]
Only dim if old brightness was higher than dim brightness.
And also fix typo :)
Comment 2 Richard Hughes 2011-09-04 20:31:07 UTC 
Created attachment 195636 [details] [review]
test patch

I'm not sure that's right; pre_dim_brightness is in absolute units (typically 0-15) and idle_brigntness is in percentage units. Could you try the attached patch and tell me if it also fixes the issue. Thanks.
Comment 3 jean-louis 2011-09-04 21:56:20 UTC 
Hi!

Thanks for you patch. This one works fine indeed.

(gnome-settings-daemon:2995): power-plugin-DEBUG: idletime alarm: 1
(gnome-settings-daemon:2995): power-plugin-DEBUG: normal to dim
(gnome-settings-daemon:2995): power-plugin-DEBUG: Doing a state transition: dim
(gnome-settings-daemon:2995): power-plugin-DEBUG: brightness already now 0/15, so ignoring dim to 4/15
Comment 4 Richard Hughes 2011-09-05 11:34:50 UTC 
commit 64c0b75c05699253d9fbceb85021e893ca2e0e7f
Author: Richard Hughes <richard@hughsie.com>
Date:   Mon Sep 5 12:34:13 2011 +0100

    power: Never idle-dim the display to a higher brightness level
    
    Resolves https://bugzilla.gnome.org/show_bug.cgi?id=658144
Comment 5 Bastien Nocera 2011-09-07 13:29:40 UTC 
*** Bug 657850 has been marked as a duplicate of this bug. ***