After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656907 - Make video preview jump around smoothly.
Make video preview jump around smoothly.
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: VoIP
unspecified
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2011-08-19 12:57 UTC by Jonny Lamb
Modified: 2011-09-26 10:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
CallWindow: drag the video preview smoothly (3.99 KB, patch)
2011-09-20 16:35 UTC, Emilio Pozuelo Monfort 		committed Details | Review

Description Jonny Lamb 2011-08-19 12:57:24 UTC 
(This started from bug #656886.)

It be awesome if when you started dragging the preview from its location but didn't actually put it anywhere that it moved back to the original location smoothly instead of jumping back in one frame?! You've got two actors here I think so if you did the animation of the one being dragged and then hid it or something? Not sure.

The same could be said for placing the preview in a new square -- you don't
line up the corners of the preview with the corners of the box, you just wait
for the box to turn red to know you've gone far enough, but it might look nice
if instead of snapping into position it glided in?
Comment 1 Jonny Lamb 2011-08-19 12:57:53 UTC 
Sorry, I mean bug #656887.
Comment 2 Emilio Pozuelo Monfort 2011-09-20 16:35:53 UTC 
Created attachment 197085 [details] [review]
CallWindow: drag the video preview smoothly
Comment 3 Guillaume Desmottes 2011-09-21 08:21:38 UTC 
Review of attachment 197085 [details] [review]:

Looks pretty good (we'll merge once we have branched). But I think we should increase the "detection range" of the new area when DnD. Atm you have to be pretty close to the new square before having it turning red.
Comment 4 Guillaume Desmottes 2011-09-26 10:21:07 UTC 
Merged to master.

Attachment 197085 [details] pushed as 68f3614 - CallWindow: drag the video preview smoothly
Comment 5 Guillaume Desmottes 2011-09-26 10:32:41 UTC 
(In reply to comment #3)
> Review of attachment 197085 [details] [review]:
> 
> Looks pretty good (we'll merge once we have branched). But I think we should
> increase the "detection range" of the new area when DnD. Atm you have to be
> pretty close to the new square before having it turning red.

I opened bug #660117 about this.