After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656887 - Dragging preview is really weird
Dragging preview is really weird
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: VoIP
unspecified
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2011-08-19 10:20 UTC by Jonny Lamb
Modified: 2011-08-22 08:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
an example for point 2 (113.63 KB, image/png)
2011-08-19 10:20 UTC, Jonny Lamb
  Details
Flip the preview in RoundedTexture->paint() (2.26 KB, patch)
2011-08-19 12:48 UTC, Emilio Pozuelo Monfort
committed Details | Review
CallWindow: correctly position the preview when dragging (1.13 KB, patch)
2011-08-19 19:05 UTC, Emilio Pozuelo Monfort
none Details | Review

Description Jonny Lamb 2011-08-19 10:20:02 UTC
Created attachment 194204 [details]
an example for point 2

1. The preview flips horizontally. I know you're aware about this one and are not sure about how to fix it yet, this is just for the record.

2. When you first click on the preview the boxes in four corners appear and the dragging starts, but the preview jumps so that the 0,0 position of the actor is where the mouse is. Once you start moving the mouse it will jump back to a more sensible position. I'll attach a screenshot showing what I mean here.

3. I say more sensible position because you anchor on the actor at the wrong place horizontally. This is probably because of the horizontal flip but if I start dragging the actor at 0,0 then it will jump to $actorwidth,0 instead. It's easy to demonstrate; it just doesn't drag normally at all and feels odd.

4. This can be completely ignored but wouldn't it be awesome (if possible?) if when you started dragging the preview from its location but didn't actually put it anywhere that it moved back to the original location smoothly instead of jumping back in one frame?! You've got two actors here I think so if you did the animation of the one being dragged and then hid it or something? Not sure.

The same could be said for placing the preview in a new square -- you don't line up the corners of the preview with the corners of the box, you just wait for the box to turn red to know you've gone far enough, but it might look nice if instead of snapping into position it glided in? Perhaps I'm asking too much here. Let me know if you want me to put this in another bug.
Comment 1 Emilio Pozuelo Monfort 2011-08-19 10:54:24 UTC
Meta bugs are bad!

(In reply to comment #0)
> 1. The preview flips horizontally. I know you're aware about this one and are
> not sure about how to fix it yet, this is just for the record.

This is blocked by  https://bugzilla.gnome.org/show_bug.cgi?id=656894
Comment 2 Emilio Pozuelo Monfort 2011-08-19 12:48:56 UTC
Created attachment 194227 [details] [review]
Flip the preview in RoundedTexture->paint()

We can't flip the preview clone that we're dragging because
of https://bugzilla.gnome.org/show_bug.cgi?id=656894, so
directly paint it flipped.

Partly fixes:
Comment 3 Jonny Lamb 2011-08-19 12:55:46 UTC
Yes this fixes points one and three.
Comment 4 Jonny Lamb 2011-08-19 12:58:15 UTC
Point four is now bug #656907.
Comment 5 Emilio Pozuelo Monfort 2011-08-19 19:05:56 UTC
Created attachment 194264 [details] [review]
CallWindow: correctly position the preview when dragging
Comment 6 Jonny Lamb 2011-08-22 08:03:35 UTC
I merged your patch after acking it. This means all the points here are fixed. Great work, thanks!

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.