After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 655597 - Tidy up .equal() methods
Tidy up .equal() methods
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: libfolks
git master
Other All
: Normal normal
: folks-0.6.0
Assigned To: folks-maint
folks-maint
Depends on: 653679 653680 653682
Blocks: 655911
 
 
Reported: 2011-07-29 19:37 UTC by Philip Withnall
Modified: 2011-08-12 16:04 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Philip Withnall 2011-07-29 19:37:52 UTC
We should tidy up the .equal() methods in various classes and interfaces, and standardise on:
class Foo {
    public bool equal (Foo other);
}

Similarly, we should standardise on the following for .hash() methods:
class Foo {
    public uint hash ();
}

The reasoning is that it's easier to write a.equal(b) than it is to write Foo.equal(a, b). Apart from that, the two styles are identical, and produce the same C API.
Comment 1 Travis Reitter 2011-08-12 16:04:52 UTC
This was solved by the addition of AbstractFieldDetails and its derivatives.