GNOME Bugzilla – Bug 653680
Change ImDetails.im_addresses to support vCard-like arbitrary parameters
Last modified: 2011-08-12 15:59:10 UTC
The main purpose of this change is to support the lossless expression of our IM addresses as vCard attributes (and vice versa). Proposed API changes: + /* { protocol => { (params, im-address), ... } } - public abstract MultiMap<string, string> im_addresses + public abstract MultiMap<string, FieldDetails> im_addresses
See bug #653682 comment #1 for my thoughts on FieldDetails.
Created attachment 192064 [details] [review] Add ImFieldDetails to provide vCard-like arbitrary parameters to IM addresses Patches from branch: http://cgit.collabora.com/git/user/treitter/folks.git/log/?h=bgo653680-im-vcard-3
Review of attachment 192064 [details] [review]: Splinter's refusing to work properly on this patch either. :-( ImFieldDetails: • Should document that null for the parameters argument is equivalent to the empty collection of parameters in the ImFieldDetails constructor. • ImFieldDetails.hash() and .equal() are missing @since documentation tags. IndividualAggregator: • Is the _prepare_pending stuff supposed to be in this patch? Rest looks fine to me!
commit 5fa28ed5366fcf9d435fd2b746c6fa5530b26fed Author: Travis Reitter <travis.reitter@collabora.co.uk> Date: Thu Jul 14 11:08:43 2011 -0700 Support vCard-like parameters for IM addresses Helps: bug#653680 - Change ImDetails.im_addresses to support vCard-like arbitrary parameters commit 961e0ff5c62e7fda61d14f5664e8d943dc166673 Author: Travis Reitter <travis.reitter@collabora.co.uk> Date: Fri Jul 8 16:35:15 2011 -0700 Clean up the way the Tracker backend tracks IM addresses. Helps: bug#653680 - Change ImDetails.im_addresses to support vCard-like arbitrary parameters