After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654864 - gtk-color-scheme customization
gtk-color-scheme customization
Status: RESOLVED INVALID
Product: gnome-tweak-tool
Classification: Applications
Component: general
3.0.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Tweak Tool maintainer(s)
GNOME Tweak Tool maintainer(s)
: 498854 499575 647686 661778 662062 (view as bug list)
Depends on: 662439
Blocks:
 
 
Reported: 2011-07-18 18:28 UTC by Sandro Mani
Modified: 2013-04-25 23:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
color switcher (2.66 KB, application/x-gzip)
2011-07-18 18:28 UTC, Sandro Mani
  Details
Patch (5.62 KB, text/plain)
2011-08-27 14:34 UTC, Sandro Mani
  Details
Screenshot (62.69 KB, image/png)
2011-08-27 14:34 UTC, Sandro Mani
  Details
Patch v2 (6.01 KB, text/plain)
2011-08-28 09:03 UTC, Sandro Mani
  Details
Patch v3 (6.44 KB, patch)
2011-10-22 14:51 UTC, Sandro Mani
none Details | Review

Description Sandro Mani 2011-07-18 18:28:55 UTC
Created attachment 192211 [details]
color switcher

Is this something that is potentially includable in gnome-tweak-tool or a won't fix because of some design decisions?
If yes I'd be willing to work on it, I already have made a little external program which does the job, see attachment.
Comment 1 John Stowers 2011-07-18 20:37:37 UTC
Is this relevant for gtk3?
Comment 2 Sandro Mani 2011-07-18 20:39:47 UTC
Yes, both gtk2 and gtk3 themes adapt to honour the new colors - only metacity does not for some odd reason I could not figure out up to now, though i.e. mutter does.
Comment 3 Sandro Mani 2011-08-27 14:34:22 UTC
Created attachment 194924 [details]
Patch

Find attached patch which implements color scheme customization. I've also attached a screenshot. I'm not really happy about the "Defaults" button, but I can't think of a way to integrate it better. Comments appreciated.
Comment 4 Sandro Mani 2011-08-27 14:34:45 UTC
Created attachment 194925 [details]
Screenshot
Comment 5 John Stowers 2011-08-28 00:43:10 UTC
(In reply to comment #3)
> Created an attachment (id=194924) [details]
> Patch
> 
> Find attached patch which implements color scheme customization. I've also
> attached a screenshot. I'm not really happy about the "Defaults" button, but I
> can't think of a way to integrate it better. Comments appreciated.

Looks ok. Some comments;

Can you fix the vertical packing? Does it look better with "Color Scheme" at the top and not the middle?

I'm also considering supporting a hierarchy of tweaks, such that the list on the left becomes a tree, and we can stick this as a child of "Theme"

Regarding defaults - I am working on a g-t-t wide system for resetting defaults, so please remove that button.
Comment 6 Sandro Mani 2011-08-28 09:03:09 UTC
Created attachment 194956 [details]
Patch v2

- Removed Defaults button
- Added yalign kwarg support to build_label_beside_widget()
- Renamed "Color Scheme" to "GTK+ color scheme"
- Fixed a tab which should have been spaces
Comment 7 John Stowers 2011-10-22 02:37:59 UTC
*** Bug 662062 has been marked as a duplicate of this bug. ***
Comment 8 John Stowers 2011-10-22 02:38:16 UTC
*** Bug 661778 has been marked as a duplicate of this bug. ***
Comment 9 John Stowers 2011-10-22 02:42:58 UTC
*** Bug 647686 has been marked as a duplicate of this bug. ***
Comment 10 John Stowers 2011-10-22 02:47:38 UTC
*** Bug 499575 has been marked as a duplicate of this bug. ***
Comment 11 John Stowers 2011-10-22 02:49:08 UTC
*** Bug 498854 has been marked as a duplicate of this bug. ***
Comment 12 Sandro Mani 2011-10-22 14:51:23 UTC
Created attachment 199724 [details] [review]
Patch v3

- Use Box instead of VBox
- Use widget.override_background_color and widget.override_color instead of deprecated widget.modify_base and widget.modify_fg
- Use Gdk.RGBA instead of Gdk.Color, since widget.override_[background_]color need a Gdk.RGBA
- Patch created against current master
Comment 13 Unsolved Cypher 2013-04-25 23:14:11 UTC
Will this be implemented? It seems like an old bug.
Comment 14 Sandro Mani 2013-04-25 23:18:47 UTC
According to [1], support for color schemes has been removed in Gtk 3.7.4, so I fear that this bug is a dead end. I'll close it accordingly.

[1] http://ftp.gnome.org/pub/GNOME/sources/gtk+/3.7/gtk+-3.7.4.news