GNOME Bugzilla – Bug 498854
Add more themable colours
Last modified: 2011-10-22 02:49:08 UTC
Judging by the number of themes hard coding colors for the window borders it would be a nice thing to allow changing window frame colors in the appearance capplet. I am attaching a patch to do this. It is against 2.20.1 and needs a wee bit of white space cleaning. If there is interest I'll port a clean version to 2.21. If this gets in I will update the Gnome themes to support it.
Created attachment 99455 [details] [review] Patch to allow dynamic window border colors. Against GnomeCC 2.20.1 for now. Patch as promised.
I'd say this is such a miniscule detail that it's not worth to expose in the UI, but then, I'm hardly an expert on theming. Thomas, any opinion on this? Patch looks ok code-wise.
I would also be reluctant to add more colours to the appearance capplet, at least not without improving the UI significantly. I'm not sure how adding a window frame colour setting would solve the original issue anyway. I suspect most Metacity themes have hard coded colours because people use images rather than using Metacity's drawing operations in their themes.
Uh, I always forget that I am not automagically CCed... Here's a late reply. To Jens' comment #2: and you don't think adjusting the tool tip colors is miniscule? The window borders are one of the most dominant colors on the desktop. Thomas, comment #3: UI clutter is one thing, granted. If I am not entirely mistaken the missing ability to dynamically adjust the window frame colors is the reason the Ubuntu Human theme does not use dynamic colors at all. They wanted to make small tweaks to the title bar color in order to make the UI less monochrome. The UI colors would become inconsistent if the user started tweaking them. Actually very few of (the popular) metacity themes use images for drawing. Besides none of the native Gnome ones does, and I think they are our main target? You guys should really try using different colors (or just a variation of bg[NORMAL]) for window borders (unless you already do, as I suspect, you scoundrels ;-P).
(In reply to comment #4) > To Jens' comment #2: and you don't think adjusting the tool tip colors is > miniscule? No. Being able to change tooltip colour is important because otherwise you won't be able to read them for certain colours. > The window borders are one of the most dominant colors on the > desktop. I'm actually not sure I understand what you mean by "window border colours". The window borders on my desktop seem to have no problems adjusting to the selected colour schemes. Why do we need a separate setting there?
To Jens' comment #5 : > No. Being able to change tooltip colour is important because otherwise you > won't be able to read them for certain colours. The same goes for the window border I guess. If I change my window border to all black/white some themes are likely to look bad. > I'm actually not sure I understand what you mean by "window border colours". > The window borders on my desktop seem to have no problems adjusting to the > selected colour schemes. Why do we need a separate setting there? They adjust to the theme because they use bg[SELECTED] or something to draw the window borders. That is fine if you like monochrome themes. The original reason for the patch was that I started using themes with different colored window borders than the selections. Fx black borders and orange highlights for the gtk theme looks really nice. Consider Green borders with yellow highlights - should also look spiffy.
*** Bug 520985 has been marked as a duplicate of this bug. ***
*** Bug 535355 has been marked as a duplicate of this bug. ***
*** Bug 588330 has been marked as a duplicate of this bug. ***
Mass move to gnome-tweak-tool, for theme handling bugs.
In general it looks like metacity/mutter will pick up more colors from the gtk theme in future *** This bug has been marked as a duplicate of bug 654864 ***