GNOME Bugzilla – Bug 654848
Remove "Create Launcher" entry from desktop nautilus
Last modified: 2011-11-14 08:36:48 UTC
Created attachment 192185 [details] [review] Remove create launcher entry from desktop nautilus Now that nautilus don't show the desktop in GNOME and that gnome-panel is optional, it seems that "Create launcher" can bring confusion with gnome-shell (this option depends on a gnome-panel binary). Here is a simple patch as it's maybe better to just remove it?
Review of attachment 192185 [details] [review]: I have kind of a mixed feeling about this; we're not showing desktop icons by default, but you can still enable them by GSettings. Users who do that probably also want to keep the ability to launch applications from the desktop? Also, gnome-panel is still installed by default in GNOME 3, as it's needed for fallback mode, so depending on a binary shipped with it is not really a problem. Anyway, if we do this, you should also remove other references to the 'New Launcher Destkop' action entry in nautilus-actions.h, nautilus-desktop-icon-view.xml and remove the lockdown conditional in nautilus-desktop-icon-view.c:real_update_menus().
Hey Cosimo, I agree the answer is not straightfoward. One of the idea is maybe to detect if the gnome-panel needed binary is installed and only to show those additional entries if it's there? Would it be acceptable to you?
(In reply to comment #2) > Hey Cosimo, > > I agree the answer is not straightfoward. > > One of the idea is maybe to detect if the gnome-panel needed binary is > installed and only to show those additional entries if it's there? Would it be > acceptable to you? Hi Didier, so, I figure this patch is because Unity is also dropping gnome-panel and the desktop icons for good, right? If so, keeping the launcher options there would only be useful for users who enable the desktop manually, and possibly install gnome-panel if it's not there. I think whatever we do, we should do it coherently, so I'd say let's remove the ability of creating launchers completely from Nautilus, as it's effectively not part of the core shell anymore, assuming this is valid for both GNOME and Unity. This means the patch also should need to purge the bits that try to call gnome-desktop-item-edit from nautilus-view.c.
Created attachment 192604 [details] [review] Remove create launcher entry from nautilus In fact, we still show the desktop on Unity (we tried two cycles ago to remove it on the netbook edition, and we got a lot of pushback from our testing). Our fallback is unity-2d in oneiric (next ubuntu release), but we provide gnome-panel (and gnome-shell) as opt-in if they install the corresponding packages. They are just not installed by default. The fact that we still have a "create a launcher" in addition to the unity launcher brought some confusion from our user testing (we got the same in gnome-panel a couple of cycle ago), where people are expecting a new bar. Hence the fact we think it makes totally sense to remove them. Here is an updated patch with (I hope), all occurences are removed. Tell me if that's fine with you or do not hesitate if I need to make any adjustement :)
Created attachment 192607 [details] [review] Remove create launcher entry from nautilus
Thanks, this looks great. I pushed the patch to git master in time for today's 3.1.4 release, closing as FIXED now.
*** Bug 564121 has been marked as a duplicate of this bug. ***
Removal of create launcher is a nasty arsed bug. Every corporate desktop will have one or more corporate applications which need to be launched by an APPLICATION LAUNCHER which allows them to set icon, path to executable AND WORKING DIRECTORY. Even if you wish to remove this from the desktop (wretched horrible idea) you STILL have to provide a clean and simple method for every corporate desktop to create an application launcher in the "favorites" or whatever you wish to call it.
This change resulting unable to create desktop icon for example in GNOME3 fallback session if the user doesn't known the proper command to launch the desktop icon create dialog (gnome-desktop-item-edit command), for example I not known this command before I not read this solution a blog post. If for example Ubuntu 11.10 are installed and the user using GNOME3 fallback session, the desktop I think is active. I not remember now this gsettings key with toggling Nautilus handle the desktop or not, but I will be try searching this configuration key. I am not sure: if the user using Unity for example with 11.10, Nautilus handling the desktop? If the next GNOME upstream release will be supporting fallback session, not have a better solution to handle this problem without complete remove this function from context menue? Didier, not possible doing a gsettings key with possible toggling this function are want enabling the user or not, independent the desktop environment if Nautilus handling the desktop? Perhaps enough to listening active the Nautilus handling the desktop related gsettings key. If this configuration key is active, need the removed context menue. Technical why matter if the minimal dependencies are installed with need the gnome-desktop-item-edit application? Attila
Hey Attila, GNOME upstream doesn't support anymore the "show the desktop" (we still show it in Unity), but as previously explain, this application is shipped by gnome-panel, not nautilus, a welcome patch I guess will be to take it and push it to nautilus to have the binary in the same source than nautilus, avoid having issues if nautilus is installed and not gnome-panel. Some environments where people can use nautilus (like ldxe or xfce) instead of their file manager can not have gnome-panel as well and they don't want to use it.