GNOME Bugzilla – Bug 652800
Empathy should notify when someone mention me at IRC
Last modified: 2012-06-20 14:18:54 UTC
Actually when someone mention my nick at IRC, Empathy notify it with make channel name(tab) red, but it's too weak. I can't check when I open another window over Empathy's window or doing something at another workspace. I wish it can notify same as when someone query me.
Created attachment 210763 [details] [review] Show MUC highlight notifications in Gnome Shell Gnome Shell filters out notifications from Empathy whose category is something the Shell shows its own notification for. However, we previously used the im.received category for notifications about being highlighted in a MUC, as well as for incoming 1-1 IM notifications. The Shell filters these out these notifications, because it shows its own 1-1 notifications, but it doesn't show MUC highlight notifications. So this patch sets a different category on notifications from chat rooms, which makes them show up in Gnome Shell. I'm prefixing the category with x-empathy, following the comment above get_category_for_event_type in empathy-notifications-approver.c. This shouldn't confuse other notification daemons, unless they were also filtering out im.received but also showed their own highlight notifications (which I find unlikely).
It's worth adding that this is controlled by the Notifications tab in preferences. If [x] Enable bubble notifications is not ticked, and [x] Enable notifications when the chat is not focused is also not ticked, then even with this patch you won't get any highlight notifications in Gnome Shell. (With them both ticked, you should already get highlight notifications in other environments for unfocused tabs.)
(Relatedly, that tab could probably stand to look a bit different if we know we're in Gnome Shell. For instance, “Disable notifications when away or busy” is meaningless in the Shell, because notifications are already hidden when we're busy.)
Review of attachment 210763 [details] [review]: ::: src/empathy-chat-window.c @@ +1570,3 @@ + { + GVariant *category = empathy_chat_is_room (chat) You dropped the g_variant_new_string() @@ +1572,3 @@ + GVariant *category = empathy_chat_is_room (chat) + ? "x-empathy.im.mentioned" + : "im.recieved"; "received".
Attachment 210763 [details] pushed as 9420ba8 - Show MUC highlight notifications in Gnome Shell
*** Bug 661731 has been marked as a duplicate of this bug. ***
(In reply to comment #2) > It's worth adding that this is controlled by the Notifications tab in > preferences. If [x] Enable bubble notifications is not ticked, and [x] Enable > notifications when the chat is not focused is also not ticked, then even with > this patch you won't get any highlight notifications in Gnome Shell. > > (With them both ticked, you should already get highlight notifications in other > environments for unfocused tabs.) I'm running Fedora 17 (empathy 3.4.2) which I verified includes this patch. However, I'm not getting notifications for IRC channel messages with my nick. I don't see a 'Notifications' tab in Preferences, either; all I see is 'General', 'Sounds', 'Calls', 'Location', 'Spell Checking', and 'Themes'. What am I missing? Thanks very much, BTW, empathy is great and this is the only bug affecting me ATM!