GNOME Bugzilla – Bug 651960
Vino server can't be activated for usage in telepathy when it's not globally enabled
Last modified: 2012-05-15 15:55:30 UTC
When a user shares their desktop via empathy, vino-server will be activated by telepathy over D-Bus to provide the necessary service. Unfortunately if it's not globally enabled it will just exit right away, causing the desktop sharing to instantly fail. Instead vino-server should startup normally, but not start any servers when not globally enabled. Optionally automatically exitting after various second. This way Telepathy can start it over dbus for its purposes.
I am guessing that this behaviour change occurred in the port to GSettings, as the server now exits immediately upon being disabled: http://git.gnome.org/browse/vino/commit/?id=13a2c919405e802fa86efa9a525fc204b9853f93 which managed to workaround a bug: https://bugzilla.gnome.org/show_bug.cgi?id=599104 I'll search for the real source of the bug, and then the change can be reverted.
Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find. *** This bug has been marked as a duplicate of bug 666205 ***
Created attachment 212677 [details] [review] add vino_dbus_listener_get_server()
Created attachment 212678 [details] [review] Add VinoServer:reject-incoming property
Created attachment 212679 [details] [review] Add --tube arg launch Vino in 'tube only' mode This fix "Share my Desktop" feature when screen sharing has been disabled in the control center. This regression has been introduced when Vino switched to GSettings as it started exiting right away when desktop sharing was disabled.
Created attachment 212680 [details] [review] vino-tube-server-managers: add tube-disconnected signal
Created attachment 212681 [details] [review] dbus-listener: relay the tube-disconnected signal
Created attachment 212682 [details] [review] Exit when tube is closed if run in tube mode
*** Bug 666205 has been marked as a duplicate of this bug. ***
Comment on attachment 212677 [details] [review] add vino_dbus_listener_get_server() Pushed to master as commit 5d9f371f9ea016b3e7033fe24912c21f39a61c3c.
Comment on attachment 212678 [details] [review] Add VinoServer:reject-incoming property Pushed to master as commit 83b6f3e602088a64b3a67e5bfebd87472889b141.
Comment on attachment 212679 [details] [review] Add --tube arg launch Vino in 'tube only' mode Pushed to master as commit be8bc1d91cad4635a7558cf34a48ae369c9ec830. I changed the argument description.
Comment on attachment 212680 [details] [review] vino-tube-server-managers: add tube-disconnected signal Pushed to master as commit 0d8ff9819fd0bdb86007480972fce3940eb8e8bc.
Comment on attachment 212681 [details] [review] dbus-listener: relay the tube-disconnected signal Pushed to master as commit 970207fdc820bb11b4e1ac23ac16b5ef37cf7d0d.
Comment on attachment 212682 [details] [review] Exit when tube is closed if run in tube mode Pushed to master as commit b2635742133a338e937387f0d7336bc8ac86f737, thanks!
Too risky for 3.2 I guess?
3.4 I meant
This is 3.6 only for the moment, as a new translatable string is added.
(In reply to comment #18) > This is 3.6 only for the moment, as a new translatable string is added. This string is just displayed in --help; we could just no translate it in stable.