After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 599104 - freezes up when disabled in preference window
freezes up when disabled in preference window
Status: RESOLVED FIXED
Product: vino
Classification: Applications
Component: Server
2.28.x
Other Linux
: Normal major
: ---
Assigned To: Vino Maintainer(s)
Vino Maintainer(s)
: 616063 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-10-20 20:09 UTC by Sam Morris
Modified: 2011-04-11 17:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
2.32 version of the patch (413 bytes, patch)
2011-03-15 18:30 UTC, Rodrigo Moya
committed Details | Review

Description Sam Morris 2009-10-20 20:09:19 UTC
When I disable the 'allow other users to view your desktop' option, the vino-server process will often freeze up. Not 100% of the time though.

Here is a backtrace of the process:

  • #0 pthread_cond_wait
    from /lib/libpthread.so.0
  • #1 ??
    from /lib/libdbus-1.so.3
  • #2 ??
    from /lib/libdbus-1.so.3
  • #3 ??
    from /lib/libdbus-1.so.3
  • #4 ??
    from /lib/libdbus-1.so.3
  • #5 ??
    from /lib/libdbus-1.so.3
  • #6 dbus_connection_send_with_reply_and_block
    from /lib/libdbus-1.so.3
  • #7 ??
    from /usr/lib/libavahi-client.so.3
  • #8 avahi_entry_group_free
    from /usr/lib/libavahi-client.so.3
  • #9 vino_mdns_stop
    at vino-mdns.c line 331
  • #10 vino_mdns_shutdown
    at vino-mdns.c line 347
  • #11 vino_prefs_sighandler
    at vino-prefs.c line 609
  • #12 <signal handler called>
  • #13 writev
    from /lib/libc.so.6
  • #14 ??
    from /lib/libdbus-1.so.3
  • #15 ??
    from /lib/libdbus-1.so.3
  • #16 ??
    from /lib/libdbus-1.so.3
  • #17 ??
    from /lib/libdbus-1.so.3
  • #18 ??
    from /lib/libdbus-1.so.3
  • #19 ??
    from /lib/libdbus-1.so.3
  • #20 ??
    from /lib/libdbus-1.so.3
  • #21 dbus_connection_send_with_reply
    from /lib/libdbus-1.so.3
  • #22 dbus_connection_send_with_reply_and_block
    from /lib/libdbus-1.so.3
  • #23 ??
    from /usr/lib/libavahi-client.so.3
  • #24 avahi_entry_group_free
    from /usr/lib/libavahi-client.so.3
  • #25 vino_mdns_stop
    at vino-mdns.c line 331
  • #26 vino_prefs_enabled_changed
    at vino-prefs.c line 100
  • #27 gconf_listeners_notify
    from /usr/lib/libgconf-2.so.4
  • #28 ??
    from /usr/lib/libgconf-2.so.4
  • #29 ??
    from /usr/lib/libgconf-2.so.4
  • #30 g_main_dispatch
    at /tmp/buildd/glib2.0-2.22.2/glib/gmain.c line 1960
  • #31 IA__g_main_context_dispatch
    at /tmp/buildd/glib2.0-2.22.2/glib/gmain.c line 2513
  • #32 g_main_context_iterate
    at /tmp/buildd/glib2.0-2.22.2/glib/gmain.c line 2591
  • #33 IA__g_main_loop_run
    at /tmp/buildd/glib2.0-2.22.2/glib/gmain.c line 2799
  • #34 IA__gtk_main
    at /tmp/buildd/gtk+2.0-2.18.2/gtk/gtkmain.c line 1216
  • #35 main
    at vino-main.c line 118

Comment 1 Karl Lattimer 2010-07-22 10:27:50 UTC
Confirmed the existence of this bug while testing app-indicators patch.

The bug appears to be in vino_mdns_stop, where avahi_entry_group_free is called, also there appear to be problems with vino_prefs_shutdown (discovered by commenting out the avahi_entry_group_free call, not investigated further).

Possible double free?
Comment 2 Karl Lattimer 2010-07-22 10:28:41 UTC
comment #1 should have included that I have tested with version 2.28.2
Comment 3 David King 2011-03-14 19:24:34 UTC
Avahi ticket 324 is a report of what may be an avahi issue. Also see Launchpad bug 31037, comment 72 and onwards:

http://avahi.org/ticket/324
https://bugs.launchpad.net/ubuntu/+source/vino/+bug/31037
Comment 4 David King 2011-03-14 20:03:04 UTC
This is fixed for me by commit 13a2c919405e802fa86efa9a525fc204b9853f93, as the server now exits immediately when it is disabled from the preferences capplet.
Comment 5 Rodrigo Moya 2011-03-15 18:30:05 UTC
Created attachment 183454 [details] [review]
2.32 version of the patch
Comment 6 David King 2011-03-20 10:17:25 UTC
*** Bug 616063 has been marked as a duplicate of this bug. ***
Comment 7 David King 2011-04-11 17:08:06 UTC
Comment on attachment 183454 [details] [review]
2.32 version of the patch

Pushed as commit 8ec0f1d36e01ecafef3079abda6539c3ae11f649, thanks.