GNOME Bugzilla – Bug 651343
New ATK Roles
Last modified: 2013-01-31 16:43:17 UTC
The following roles were agreed upon as being desirable additions to ATK: * ATK_ROLE_TABLE_ROW * ATK_ROLE_TREE_ITEM * ATK_ROLE_DOCUMENT_SPREADSHEET * ATK_ROLE_DOCUMENT_PRESENTATION * ATK_ROLE_DOCUMENT_TEXT * ATK_ROLE_DOCUMENT_WEB * ATK_ROLE_DOCUMENT_EMAIL * ATK_ROLE_LIST_BOX * ATK_ROLE_GROUPING (a group of widgets, can have a title) * ATK_ROLE_IMAGE_MAP * ATK_ROLE_NOTIFICATION * ATK_ROLE_COMMENT (e.g. OOo/LibreOffice Writer or Calc: Insert->Comment)
[Mass-reassigning open atk bug reports for better trackability as requested in https://bugzilla.gnome.org/show_bug.cgi?id=653179 . PLEASE NOTE: If you have watched the previous assignee of this bug report as a workaround for actually getting notified of changes in atk bugs, you yourself will now have to add atk-maint@gnome.bugs to your watchlist at the bottom of https://bugzilla.gnome.org/userprefs.cgi?tab=email to keep watching atk bug reports in GNOME Bugzilla. Sorry for the noise: Feel free to filter for this comment in order to mass-delete the triggered bugmail.]
I'm thinking we might also want ATK_ROLE_INFO_BAR. Uses: * Browsers that display those 'do you want to save this password?' bar * http://developer.gnome.org/gtk/stable/GtkInfoBar.html
Created attachment 191168 [details] [review] proposed patch Tested along with the patches I am about to attach to bug 653872 and bug 653874, and this change to Gtk+ 3: ~~~~~~ diff --git a/gtk/gtkinfobar.c b/gtk/gtkinfobar.c index 87f6d3b..cb0e02d 100644 --- a/gtk/gtkinfobar.c +++ b/gtk/gtkinfobar.c @@ -1106,7 +1106,7 @@ gtk_info_bar_set_message_type (GtkInfoBar *info_bar, GtkStockItem item; const char *stock_id = NULL; - atk_object_set_role (atk_obj, ATK_ROLE_ALERT); + atk_object_set_role (atk_obj, ATK_ROLE_INFO_BAR); switch (message_type) { ~~~~~~ Accerciser now reports that GtkInfoBar instances from gtk3-demo as having role 'info bar'. Please review. Thanks!
Comment on attachment 191168 [details] [review] proposed patch Committed to the master branch: http://git.gnome.org/browse/atk/commit/?id=4f88969d708b83293d656afb79375538bc95973f
Gtk now has a "level bar" widget intended to be used as a level indicator (for instance, to display the strength of a password or the charge level of a battery). Should we add an atk role for this? I'm not sure whether, ie, it makes sense to use ATK_ROLE_INFO_BAR or not.
Created attachment 231528 [details] [review] Patch to add ATK_ROLE_LEVEL_BAR
Re-opening because I think that we want the new role, and it seems easier than filing a new bug.
Review of attachment 231528 [details] [review]: After a chat on the weekly a11y meeting, we concluded that having that role would be good. Looks good to me.
Comment on attachment 231528 [details] [review] Patch to add ATK_ROLE_LEVEL_BAR Committed as e5d2a9.