After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 650598 - Cannot Enter Nth Day of Month Scheduled Transactions
Cannot Enter Nth Day of Month Scheduled Transactions
Status: RESOLVED FIXED
Product: GnuCash
Classification: Other
Component: Engine
2.4.x
Other All
: Normal normal
: ---
Assigned To: Derek Atkins
Christian Stimming
: 656316 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-05-19 14:59 UTC by Rich
Modified: 2018-06-29 22:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patches to allow scheduling of Nth Day of Month Transactions. (13.45 KB, application/octet-stream)
2011-05-19 14:59 UTC, Rich
  Details
Patches to allow scheduling of Nth Day of Month Transactions. (14.97 KB, patch)
2011-05-21 15:04 UTC, Rich
committed Details | Review
Add correction to original patch (887 bytes, patch)
2011-06-08 17:20 UTC, Rich
committed Details | Review

Description Rich 2011-05-19 14:59:39 UTC
Created attachment 188134 [details]
Patches to allow scheduling of Nth Day of Month Transactions.

I have transactions that should be scheduled on the second Wednesday of every month.  There is presently no way to do it.  I made changes and have tested them. I have attached the patches for review.
Comment 1 Rich 2011-05-21 15:04:44 UTC
Created attachment 188300 [details] [review]
Patches to allow scheduling of Nth Day of Month Transactions.

Revised previous patch to include fix for nth_weekday_compare function, which did not work correctly for type period type: PERIOD_NTH_WEEKDAY
Comment 2 Rich 2011-05-21 15:09:15 UTC
This patch enhances the scheduled transaction feature to allow nth day of week monthly entries. The weekend adjust spinner is ignored when an nth day of week entry is scheduled.
Comment 3 Christian Stimming 2011-05-21 22:05:36 UTC
Comment on attachment 188300 [details] [review]
Patches to allow scheduling of Nth Day of Month Transactions.

I'm surprised this is possible without having to modify the XML or SQL data storage. But in that case it can go into SVN immediately.
Comment 4 Rich 2011-05-23 14:50:07 UTC
(In reply to comment #3)
> (From update of attachment 188300 [details] [review])
> I'm surprised this is possible without having to modify the XML or SQL data
> storage. But in that case it can go into SVN immediately.

I don't have permission to add to SVN.  It would be nice to have it in the next release.  I can't cross compile for windows, but it works well on Ubuntu with the new Netbeans IDE.
Comment 5 Christian Stimming 2011-05-23 19:16:53 UTC
Comment on attachment 188300 [details] [review]
Patches to allow scheduling of Nth Day of Month Transactions.

r20672, thanks a lot! I had to modify this a bit to adapt it to our code indentation, and also add translation of your "weeks[]" strings.
Comment 6 Rich 2011-05-24 10:25:27 UTC
I appreciate your efforts correcting my lax coding.  I'm just a beginner with the gnu standards and have a lot to learn.
Comment 7 Rich 2011-06-08 17:20:05 UTC
Created attachment 189484 [details] [review]
Add correction to original patch

Correction to original patch allowing Nth Day of Month Transactions.
This patch corrects a problem with Nth Day of Month display future months transactions.
Comment 8 Rich 2011-06-09 14:19:34 UTC
Please commit the patch as soon as possible.
Comment 9 Geert Janssens 2011-06-09 15:17:48 UTC
Comment on attachment 189484 [details] [review]
Add correction to original patch

from r20742. Thanks a lot !
Comment 10 Mike Evans 2013-02-07 12:30:50 UTC
*** Bug 656316 has been marked as a duplicate of this bug. ***
Comment 11 David Carlson 2013-02-07 14:30:43 UTC
How many bugs are there that are marked resolved fixed but they are still broken in the current release?  I can name several others that have been "Resolved" for over a year so they do not appear in the search for open issues, yet new users are still finding them in the current release.  How about adding a status "Awaiting next Release"?
Comment 12 Geert Janssens 2013-02-07 14:42:24 UTC
A valid point, which crossed my mind on occasion as well.

However, as a comment on a closed bug this is not very useful (even though the bug is an example to illustrate your point). You propose a change in the development process. That could at least be considered a general enhancement request, but better even be discussed openly on the gnucash-devel mailing list.
Comment 13 John Ralls 2017-09-24 22:44:58 UTC
Reassign version to 2.4.x so that individual 2.4 versions can be retired.
Comment 14 John Ralls 2018-06-29 22:58:06 UTC
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=650598. Please update any external references or bookmarks.