(In reply to comment #0)
> Now that we can access the addressbook using Folks, Empathy should be able to
> call contacts having a phone number using SIP accounts.
> 
> I don't think we should automatically display those contacts in the contact
> list, but maybe they could be displayed in live search?

I assume you mean you'll want to filter out non-chat-/call-able Individuals. But any Individuals that have, eg, both EDS and Telepathy Personas should show up in the regular contact list. You don't need to show irrelevant details (eg, postal address) in any of your views, but you should use the EDS avatar, alias, etc.

EDS will be the primary backend, which will mean that user edits are stored there, so they should be preferred. If you just use the values on the Individual (rather than specifically iterating their TpfPersonas), you'll be doing the right thing automatically.

> Also, do we need a "Use this account for phone call" account option as on the
> N900?

Probably, since the source account can sometimes determine whether the other person will accept the call (in case you call from an account they're not familiar with, don't want to pick up from at work, etc.). And especially since calling accounts can sometimes have a monetary cost per call/time.

*** Bug 655452 has been marked as a duplicate of this bug. ***

I'd like to see these contacts as callable (although of course offline, unless merged with a callable & online contact) in the contact list too, when I do a type-ahead search.

(In reply to comment #3)
> I'd like to see these contacts as callable (although of course offline, unless
> merged with a callable & online contact) in the contact list too, when I do a
> type-ahead search.

Wait, that's exactly what you said. Yes; please do it. :D

(In reply to comment #0)
> Also, do we need a "Use this account for phone call" account option as on the
> N900?

This part is done: bug #657220

Let's start with the simple case: a TP contact linked with an EDS one, you right click on it from your contact list and want to call him.

Here is what I have so far: http://people.collabora.com/~cassidy/phone.jpg

My plan is to add a "Call ..." entry per phone number for this contact iff user has at least one "phone enabled" account connected. If not those are unsensitive.

I'm not sure how I should deal with the "more than one phone account connected" case. Add a sub-menu to pick the account to use to place the call? A popup asking once we have clicked?

Created attachment 194824 [details] [review]
export empathy_account_has_uri_scheme_tel()

Created attachment 194825 [details] [review]
add EmpathyAccountSelectorDialog

Dialog asking user to pick an account from a pre-defined list.

Created attachment 194826 [details] [review]
Allow to call phone number of contacts

Review of attachment 194826 [details] [review]:

::: libempathy-gtk/empathy-individual-menu.c
@@ +266,3 @@
+    }
+
+  g_list_free_full (accounts, (GDestroyNotify) g_object_ref);

tp_account_manager_get_valid_accounts() returns the container, so you don't have to unref them here. And you made a typo anyway with _ref instead of _unref.

@@ +281,3 @@
+  result = (accounts != NULL);
+
+  g_list_free_full (accounts, (GDestroyNotify) g_object_ref);

s/ref/unref/

@@ +355,3 @@
+    }
+
+  g_list_free_full (accounts, (GDestroyNotify) g_object_ref);

unref

Review of attachment 194825 [details] [review]:

::: libempathy-gtk/empathy-account-selector-dialog.c
@@ +90,3 @@
+          COL_NAME, tp_account_get_display_name (account),
+          -1);
+    }

gtk_list_store_insert_with_values() instead of _append() + _set()

All fixed in http://cgit.collabora.com/git/user/cassidy/empathy/log/?h=call-tel-650112

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.