After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 657220 - Add option to use account for phone calls
Add option to use account for phone calls
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Accounts
2.33.x
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2011-08-24 08:31 UTC by Guillaume Desmottes
Modified: 2011-08-24 14:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
account-settings: add API to set 'tel' in the URISchemes property of the account (4.78 KB, patch)
2011-08-24 11:53 UTC, Guillaume Desmottes 		committed Details | Review
account-widget: add empathy_account_widget_get_settings() (1.55 KB, patch)
2011-08-24 11:53 UTC, Guillaume Desmottes 		committed Details | Review
widget-sip: load/save file in Glade (22.44 KB, patch)
2011-08-24 11:54 UTC, Guillaume Desmottes 		committed Details | Review
account-widget-sip: add option to mark account as being able to call phones (4.35 KB, patch)
2011-08-24 11:54 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2011-08-24 08:31:13 UTC 
We should use http://telepathy.freedesktop.org/spec/Account_Interface_Addressing.html to let users to say that an account (typically SIP) can be used to make phone calls.
Comment 1 Guillaume Desmottes 2011-08-24 11:53:56 UTC 
Created attachment 194572 [details] [review]
account-settings: add API to set 'tel' in the URISchemes property of the account
Comment 2 Guillaume Desmottes 2011-08-24 11:53:59 UTC 
Created attachment 194573 [details] [review]
account-widget: add empathy_account_widget_get_settings()
Comment 3 Guillaume Desmottes 2011-08-24 11:54:02 UTC 
Created attachment 194574 [details] [review]
widget-sip: load/save file in Glade

No change has been done, this is just to keep commits simpler.
Comment 4 Guillaume Desmottes 2011-08-24 11:54:05 UTC 
Created attachment 194575 [details] [review]
account-widget-sip: add option to mark account as being able to call phones
Comment 5 Xavier Claessens 2011-08-24 12:42:41 UTC 
Review of attachment 194575 [details] [review]:

::: libempathy-gtk/empathy-account-widget-sip.c
@@ +161,3 @@
+      if (empathy_account_settings_has_uri_scheme_tel (
+            empathy_account_widget_get_settings (self)))
+        gtk_toggle_button_set_active (checkbutton_tel, TRUE);

gtk_toggle_button_set_active (checkbutton_tel, empathy_account_settings_has_uri_scheme_tel (empathy_account_widget_get_settings (self)));

To not depend on the default value set in glade is FALSE? nitpicking probably :)
Comment 6 Xavier Claessens 2011-08-24 12:42:57 UTC 
The rest seems good.
Comment 7 Guillaume Desmottes 2011-08-24 14:27:17 UTC 
(In reply to comment #5)
> Review of attachment 194575 [details] [review]:
> 
> ::: libempathy-gtk/empathy-account-widget-sip.c
> @@ +161,3 @@
> +      if (empathy_account_settings_has_uri_scheme_tel (
> +            empathy_account_widget_get_settings (self)))
> +        gtk_toggle_button_set_active (checkbutton_tel, TRUE);
> 
> gtk_toggle_button_set_active (checkbutton_tel,
> empathy_account_settings_has_uri_scheme_tel
> (empathy_account_widget_get_settings (self)));
> 
> To not depend on the default value set in glade is FALSE? nitpicking probably
> :)

Good point; fixed. merging.
Comment 8 Guillaume Desmottes 2011-08-24 14:28:07 UTC 
Attachment 194572 [details] pushed as 1ef053f - account-settings: add API to set 'tel' in the URISchemes property of the account
Attachment 194573 [details] pushed as fe4fd76 - account-widget: add empathy_account_widget_get_settings()
Attachment 194574 [details] pushed as 1363e49 - widget-sip: load/save file in Glade
Attachment 194575 [details] pushed as 96d6384 - account-widget-sip: add option to mark account as being able to call phones